From: Ali Polatel <alip@exherbo.org>
To: Austin Clements <amdragon@mit.edu>
Cc: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH] ruby: extern linkage portability improvement
Date: Tue, 15 May 2012 18:08:45 +0300 [thread overview]
Message-ID: <CADv3eywyAaqtAhzYJFjVp9xpWcPv35L1CGPYK3PK_GaDrAJOVw@mail.gmail.com> (raw)
In-Reply-To: <20120513171917.GL11804@mit.edu>
2012/5/13 Austin Clements <amdragon@mit.edu>:
> Quoth Tomi Ollila on May 10 at 8:12 pm:
>> Some C compilers are stricter when it comes to (tentative) definition
>> of a variable -- in those compilers introducing variable without 'extern'
>> keyword always allocates new 'storage' to the variable and linking all
>> these modules fails due to duplicate symbols.
>>
>> This change uses some macro trickery to avoid writing every variable twice.
>>
>> This is reimplementation of Charlie Allom's patch:
>> id:"1336481467-66356-1-git-send-email-charlie@mediasp.com"
>>
>> combining information from other change made by Ali Polatel.
>> ---
>>
>> Charlie: could you test whether this patch actually work ? :)
>>
>> Everyone: what do you think of the "hiding extern" macro trick ?
>
> This seems like a hacky and nonstandard way to do this. Granted, the
> standard way to do this---always declare variables extern in .h files
> and also give a non-extern definition in exactly one .c file---is more
> verbose, but nobody will be surprised or confused by it.
I fully agree or otherwise I'd suggest using:
http://minnie.tuhs.org/cgi-bin/utree.pl?file=V7/usr/src/cmd/sh/mac.h
>> bindings/ruby/defs.h | 56 +++++++++++++++++++++++++++----------------------
>> bindings/ruby/init.c | 2 +
>> 2 files changed, 33 insertions(+), 25 deletions(-)
>>
>> diff --git a/bindings/ruby/defs.h b/bindings/ruby/defs.h
>> index 85d8205..2531760 100644
>> --- a/bindings/ruby/defs.h
>> +++ b/bindings/ruby/defs.h
>> @@ -24,31 +24,37 @@
>> #include <ruby.h>
>> #include "notmuch.h"
>>
>> -VALUE notmuch_rb_cDatabase;
>> -VALUE notmuch_rb_cDirectory;
>> -VALUE notmuch_rb_cFileNames;
>> -VALUE notmuch_rb_cQuery;
>> -VALUE notmuch_rb_cThreads;
>> -VALUE notmuch_rb_cThread;
>> -VALUE notmuch_rb_cMessages;
>> -VALUE notmuch_rb_cMessage;
>> -VALUE notmuch_rb_cTags;
>> -
>> -VALUE notmuch_rb_eBaseError;
>> -VALUE notmuch_rb_eDatabaseError;
>> -VALUE notmuch_rb_eMemoryError;
>> -VALUE notmuch_rb_eReadOnlyError;
>> -VALUE notmuch_rb_eXapianError;
>> -VALUE notmuch_rb_eFileError;
>> -VALUE notmuch_rb_eFileNotEmailError;
>> -VALUE notmuch_rb_eNullPointerError;
>> -VALUE notmuch_rb_eTagTooLongError;
>> -VALUE notmuch_rb_eUnbalancedFreezeThawError;
>> -VALUE notmuch_rb_eUnbalancedAtomicError;
>> -
>> -ID ID_call;
>> -ID ID_db_create;
>> -ID ID_db_mode;
>> +#ifdef RUBY_INIT_C
>> +#define extern
>> +#endif
>> +
>> +extern VALUE notmuch_rb_cDatabase;
>> +extern VALUE notmuch_rb_cDirectory;
>> +extern VALUE notmuch_rb_cFileNames;
>> +extern VALUE notmuch_rb_cQuery;
>> +extern VALUE notmuch_rb_cThreads;
>> +extern VALUE notmuch_rb_cThread;
>> +extern VALUE notmuch_rb_cMessages;
>> +extern VALUE notmuch_rb_cMessage;
>> +extern VALUE notmuch_rb_cTags;
>> +
>> +extern VALUE notmuch_rb_eBaseError;
>> +extern VALUE notmuch_rb_eDatabaseError;
>> +extern VALUE notmuch_rb_eMemoryError;
>> +extern VALUE notmuch_rb_eReadOnlyError;
>> +extern VALUE notmuch_rb_eXapianError;
>> +extern VALUE notmuch_rb_eFileError;
>> +extern VALUE notmuch_rb_eFileNotEmailError;
>> +extern VALUE notmuch_rb_eNullPointerError;
>> +extern VALUE notmuch_rb_eTagTooLongError;
>> +extern VALUE notmuch_rb_eUnbalancedFreezeThawError;
>> +extern VALUE notmuch_rb_eUnbalancedAtomicError;
>> +
>> +extern ID ID_call;
>> +extern ID ID_db_create;
>> +extern ID ID_db_mode;
>> +
>> +#undef extern
>>
>> /* RSTRING_PTR() is new in ruby-1.9 */
>> #if !defined(RSTRING_PTR)
>> diff --git a/bindings/ruby/init.c b/bindings/ruby/init.c
>> index 3fe60fb..b2dc7f6 100644
>> --- a/bindings/ruby/init.c
>> +++ b/bindings/ruby/init.c
>> @@ -18,7 +18,9 @@
>> * Author: Ali Polatel <alip@exherbo.org>
>> */
>>
>> +#define RUBY_INIT_C
>> #include "defs.h"
>> +#undef RUBY_INIT_C
>>
>> /*
>> * Document-module: Notmuch
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2012-05-15 15:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 17:12 [PATCH] ruby: extern linkage portability improvement Tomi Ollila
2012-05-13 17:19 ` Austin Clements
2012-05-15 15:08 ` Ali Polatel [this message]
2012-05-15 15:31 ` Tomi Ollila
2012-06-24 11:20 ` David Bremner
2012-05-14 12:42 ` Charlie Allom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADv3eywyAaqtAhzYJFjVp9xpWcPv35L1CGPYK3PK_GaDrAJOVw@mail.gmail.com \
--to=alip@exherbo.org \
--cc=amdragon@mit.edu \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).