From: Ronny Chevalier <chevalier.ronny@gmail.com>
To: David Bremner <david@tethera.net>
Cc: notmuch@notmuchmail.org
Subject: Re: notmuch_thread_get_authors
Date: Tue, 21 Apr 2015 14:22:07 +0200 [thread overview]
Message-ID: <CABPZE7JGzfSMWKpxKqJeCbpsDhX4xj_HoNoKFL8MbYv9xYpQ7w@mail.gmail.com> (raw)
In-Reply-To: <87618qfk5l.fsf@maritornes.cs.unb.ca>
On Tue, Apr 21, 2015 at 1:35 AM, David Bremner <david@tethera.net> wrote:
> Ronny Chevalier <chevalier.ronny@gmail.com> writes:
>
>> Hi,
>>
>> I would like to know the reason behind the way we get authors from a
>> thread, with notmuch_thread_get_authors.
>>
>
> there is some related patches/discussion at
>
> http://thread.gmane.org/gmane.mail.notmuch.general/19422
Ok thanks.
Since I just subscribed to the mailing list, I can't reply to this the
thread so I reply here.
Austin Clements wrote:
> And I think there's a fairly easy way to do it in C code that will
> also prevent library interface bloat: instead of introducing new
> library APIs to get at this information, just use the existing
> notmuch_thread_get_messages API and construct the matched and
> non-matched lists in the CLI. Doing it in the CLI wouldn't require
> the library to export yet another string list structure, which is
> always a huge pain (thanks C!), and wouldn't introduce more "helper"
> functions into the library API.
I disagree with what Austin said. Because this does not solve the
issue at all (or I misunderstood). The issue is with the notmuch API,
if someone is using this library there no way it can parse properly
the authors.
In my case I am not using the CLI but the notmuch library, fixing this
in the CLI is just an hack, and it does not fix the issue for the
library users.
Furthermore, I do not see why providing a string list NULL-terminated
in C is a huge pain?
Otherwise, I agree with Mark Walters comments on the patch.
If no one is working to fix this at the moment, I can send a patch?
Ronny
next prev parent reply other threads:[~2015-04-21 12:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 16:04 notmuch_thread_get_authors Ronny Chevalier
2015-04-20 23:35 ` notmuch_thread_get_authors David Bremner
2015-04-21 12:22 ` Ronny Chevalier [this message]
2015-04-22 1:28 ` notmuch_thread_get_authors Austin Clements
2015-04-22 1:33 ` notmuch_thread_get_authors David Bremner
2015-04-22 2:01 ` notmuch_thread_get_authors Ronny Chevalier
2015-04-22 2:22 ` notmuch_thread_get_authors Austin Clements
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABPZE7JGzfSMWKpxKqJeCbpsDhX4xj_HoNoKFL8MbYv9xYpQ7w@mail.gmail.com \
--to=chevalier.ronny@gmail.com \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).