From: Jani Nikula <jani@nikula.org>
To: David Bremner <david@tethera.net>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH v2] emacs: add function to toggle display of all multipart/alternative parts
Date: Sun, 24 Jun 2012 10:10:01 +0300 [thread overview]
Message-ID: <CAB+hUn9_Ba6Cr55VCjj3=BxnshFOBBOe=G11ReECFkN_RrwUwQ@mail.gmail.com> (raw)
In-Reply-To: <87zk7vasdd.fsf@zancas.localnet>
[-- Attachment #1: Type: text/plain, Size: 902 bytes --]
On Jun 23, 2012 1:34 AM, "David Bremner" <david@tethera.net> wrote:
>
> Jani Nikula <jani@nikula.org> writes:
>
> >
> > A small wrinkle is that in order to make the variable survive
> > notmuch-show-refresh-view (which is required for expanding/collapsing
> > the parts, but ends up calling kill-all-local-variables through
> > notmuch-show-mode) it is necessary to give it the permanent-local
> > property.
>
> The code looks simple enough; should we apply this patch while we wait
> for something fancier?
Applying this doesn't make the fancy stuff harder to do at all. And this
doesn't have a key binding, on purpose, so we're not committed to that
either. But then I'm biased...
> I don't really know how to evaluate the
> permanent-local bit.
All the other show mode toggles use that too. It's probably less surprising
like this than the permanently local only as needed approach in v1.
>
> d
[-- Attachment #2: Type: text/html, Size: 1187 bytes --]
next prev parent reply other threads:[~2012-06-24 7:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 15:55 [PATCH] emacs: add function to toggle display of all multipart/alternative parts Jani Nikula
2012-06-18 21:26 ` Jameson Graef Rollins
2012-06-19 6:56 ` Mark Walters
2012-08-09 20:52 ` Jameson Graef Rollins
2012-08-10 7:10 ` [PATCH v2] " Mark Walters
2012-08-10 14:53 ` Jani Nikula
2012-08-10 16:18 ` Jameson Graef Rollins
2012-08-10 16:39 ` Jani Nikula
2012-08-10 16:58 ` Mark Walters
2012-08-10 17:49 ` Jameson Graef Rollins
2012-08-12 17:39 ` [PATCH 1/2] test: add emacs show mode test for toggling display of multipart/alternative Jameson Graef Rollins
2012-08-12 17:39 ` [PATCH 2/2] test: move all emacs show tests to emacs-show test script Jameson Graef Rollins
2012-08-31 19:44 ` David Bremner
2012-10-20 2:31 ` [PATCH 1/2] test: add emacs show mode test for toggling display of multipart/alternative Ethan Glasser-Camp
2012-10-09 22:21 ` [PATCH v2] emacs: add function to toggle display of all multipart/alternative parts Jeremy Nickurak
2012-10-19 16:36 ` Ethan Glasser-Camp
2012-06-19 6:57 ` [PATCH] " Jani Nikula
2012-06-19 20:14 ` [PATCH v2] " Jani Nikula
2012-06-19 20:25 ` Jani Nikula
2012-06-22 22:34 ` David Bremner
2012-06-24 7:10 ` Jani Nikula [this message]
2012-06-24 18:56 ` Mark Walters
2012-10-19 16:14 ` [PATCH] Add NEWS item for multipart/alternative toggle Ethan Glasser-Camp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAB+hUn9_Ba6Cr55VCjj3=BxnshFOBBOe=G11ReECFkN_RrwUwQ@mail.gmail.com' \
--to=jani@nikula.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).