From: Jani Nikula <jani@nikula.org>
To: Pieter Praet <pieter@praet.org>
Cc: Tomi Ollila <tomi.ollila@iki.fi>, Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH 2/2] NEWS: fix some old typos and trailing whitespace
Date: Thu, 17 Nov 2011 08:21:59 +0200 [thread overview]
Message-ID: <CAB+hUn9Ysf9KGVCFAas2JfH+CZ0yFC47oWZHBdRT9u=i21TkZg@mail.gmail.com> (raw)
In-Reply-To: <87d3crd9yr.fsf@praet.org>
[-- Attachment #1: Type: text/plain, Size: 901 bytes --]
On Nov 16, 2011 11:39 PM, "Pieter Praet" <pieter@praet.org> wrote:
>
> On Wed, 16 Nov 2011 22:54:35 +0200, Tomi Ollila <tomi.ollila@iki.fi>
wrote:
> > On Wed, 16 Nov 2011 21:37:50 +0100, Pieter Praet <pieter@praet.org>
wrote:
> > > No further explanation needed.
> > > ---
> > > NEWS | 14 +++++++-------
> > > 1 files changed, 7 insertions(+), 7 deletions(-)
> >
> > The 'No further explanation needed.' should be *BELOW* the waistline
(---) ;);
> > now it goes to the commit message which is probably not what anybody
wants.
> >
>
> That was intended :)
>
> Empty commit messages are frowned upon (even if the commit subject is
> sufficiently descriptive), so "rather a pointless one than none?" :)
Generally I think the message should be self-contained and understandable
without the subject line, so IMHO a full meaningful sentence is better than
one/none, even if it's repetition.
BR,
Jani.
[-- Attachment #2: Type: text/html, Size: 1276 bytes --]
next prev parent reply other threads:[~2011-11-17 6:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-13 14:19 Winter is coming [upcoming release 0.10] David Bremner
2011-11-13 16:34 ` [PATCH] Don't link libnotmuch if libutil isn't linked in properly Tom Prince
2011-11-13 17:05 ` [PATCH] Link libutil using filenmae, rather than using -l Tom Prince
2011-11-13 19:09 ` David Bremner
2011-11-13 17:09 ` [PATCH] Don't link libnotmuch if libutil isn't linked in properly Tom Prince
2011-11-19 19:20 ` David Bremner
2011-11-13 17:13 ` Winter is coming [upcoming release 0.10] Austin Clements
2011-11-16 3:11 ` David Bremner
2011-11-16 3:13 ` [PATCH] NEWS: discuss contrib and nmbug David Bremner
2011-11-16 11:48 ` David Bremner
2011-11-16 15:30 ` Winter is coming [upcoming release 0.10] Tomi Ollila
2011-11-16 15:43 ` Austin Clements
2011-11-16 17:08 ` David Bremner
2011-11-16 20:37 ` Pieter Praet
2011-11-16 20:37 ` [PATCH 1/2] NEWS: add entries for stashing-related keybinding and tests Pieter Praet
2011-11-16 20:37 ` [PATCH 2/2] NEWS: fix some old typos and trailing whitespace Pieter Praet
2011-11-16 20:54 ` Tomi Ollila
2011-11-16 21:38 ` Pieter Praet
2011-11-17 6:21 ` Jani Nikula [this message]
2012-01-12 17:06 ` Pieter Praet
2012-01-13 3:11 ` David Bremner
2012-01-14 9:01 ` Pieter Praet
2011-11-16 22:17 ` Winter is coming [upcoming release 0.10] David Bremner
2011-11-16 23:26 ` Pieter Praet
2011-11-21 11:50 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAB+hUn9Ysf9KGVCFAas2JfH+CZ0yFC47oWZHBdRT9u=i21TkZg@mail.gmail.com' \
--to=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
--cc=pieter@praet.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).