From: Jani Nikula <jani@nikula.org>
To: Jameson Graef Rollins <jrollins@finestructure.net>
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH 4/6] cli: intialize crypto structure in show and reply
Date: Thu, 17 May 2012 19:31:59 +0300 [thread overview]
Message-ID: <CAB+hUn9DdeaFj-hUNb_c1V3QLsbWjsE7_hpuOpDqWseayASdKQ@mail.gmail.com> (raw)
In-Reply-To: <877gwaeve1.fsf@servo.finestructure.net>
[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]
On May 17, 2012 5:26 PM, "Jameson Graef Rollins" <jrollins@finestructure.net>
wrote:
>
> On Thu, May 17 2012, Jani Nikula <jani@nikula.org> wrote:
> > On Thu, 17 May 2012, Jameson Graef Rollins <jrollins@finestructure.net>
wrote:
> >> This makes sure it has proper initialization values when it's created.
> >
> > Please don't do this. It's unnecessary; if one field is initialized with
> > a designated initializer, the rest are initialized to zero (or NULL).
>
> It may be technically unnecessary, but why is that a reason to not do
> it? I intentionally did this to make it clear what the defaults are.
> Otherwise the defaults are essentially undefined, which is not good.
> Maybe the structure initializes to the correct defaults, but why count
> on that when we can set them to the correct default, and have it clear
> to readers of the code?
The values are not undefined, they are properly initialized, and we can
count on it. For sure, not maybe. If you want to explicitly set them for
clarity, it's a matter of taste. Personally I find it too verbose, but then
again notmuch code is generally fairly verbose. If you insist on it, please
at least drop the extra temp crypto variable, and initialize the struct in
one initializer.
BR,
Jani.
>
> jamie.
[-- Attachment #2: Type: text/html, Size: 1634 bytes --]
next prev parent reply other threads:[~2012-05-17 16:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 21:55 [PATCH 0/6] cli: improve handling of crypto parameters contexts Jameson Graef Rollins
2012-05-16 21:55 ` [PATCH 1/6] cli: new crypto structure to store crypto contexts and parameters Jameson Graef Rollins
2012-05-16 21:55 ` [PATCH 2/6] cli: modify mime_node_context to use the new notmuch_crypto_t Jameson Graef Rollins
2012-05-16 21:55 ` [PATCH 3/6] cli: modify mime_node_open to take crypto struct as argument Jameson Graef Rollins
2012-05-16 21:55 ` [PATCH 4/6] cli: intialize crypto structure in show and reply Jameson Graef Rollins
2012-05-16 21:55 ` [PATCH 5/6] cli: new crypto verify flag to handle verification Jameson Graef Rollins
2012-05-16 21:55 ` [PATCH 6/6] cli: lazily create the crypto gpg context only when needed Jameson Graef Rollins
2012-05-17 22:29 ` Austin Clements
2012-05-17 7:47 ` [PATCH 4/6] cli: intialize crypto structure in show and reply Jani Nikula
2012-05-17 14:26 ` Jameson Graef Rollins
2012-05-17 16:31 ` Jani Nikula [this message]
2012-05-17 16:45 ` Jameson Graef Rollins
2012-05-17 20:23 ` Jani Nikula
2012-05-17 20:53 ` Jameson Graef Rollins
2012-05-17 21:51 ` Daniel Kahn Gillmor
2012-05-18 6:59 ` Tomi Ollila
2012-05-18 8:20 ` Jani Nikula
2012-05-18 17:09 ` Daniel Kahn Gillmor
2012-05-17 22:29 ` Austin Clements
2012-05-17 7:40 ` [PATCH 3/6] cli: modify mime_node_open to take crypto struct as argument Jani Nikula
2012-05-17 22:26 ` Austin Clements
2012-05-17 7:37 ` [PATCH 2/6] cli: modify mime_node_context to use the new notmuch_crypto_t Jani Nikula
2012-05-17 7:36 ` [PATCH 1/6] cli: new crypto structure to store crypto contexts and parameters Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAB+hUn9DdeaFj-hUNb_c1V3QLsbWjsE7_hpuOpDqWseayASdKQ@mail.gmail.com \
--to=jani@nikula.org \
--cc=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).