From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YFKzF9SZWWLgCQEAgWs5BA (envelope-from ) for ; Fri, 15 Apr 2022 18:14:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 6Ld8ENSZWWJBSwAAG6o9tA (envelope-from ) for ; Fri, 15 Apr 2022 18:14:12 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C597C13CA1 for ; Fri, 15 Apr 2022 18:14:11 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id AD1745F70E; Fri, 15 Apr 2022 16:04:14 +0000 (UTC) Received: from mail-oo1-xc2d.google.com (mail-oo1-xc2d.google.com [IPv6:2607:f8b0:4864:20::c2d]) by mail.notmuchmail.org (Postfix) with ESMTPS id 64B255F706 for ; Fri, 15 Apr 2022 16:04:11 +0000 (UTC) Received: by mail-oo1-xc2d.google.com with SMTP id 1-20020a4a0901000000b003296ea2104eso1425756ooa.13 for ; Fri, 15 Apr 2022 09:04:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yNDQAJFSLJLfThTJNbvSt9PeMOmz29jO4MB8fgsGzuk=; b=m5asjieJIIbl9kBCw9MgMlzY6JMFz/nhsZUokHD+9Ci7IY0OYeSLtHBYOUeBEPVDQu 9XbHsEiY3cakm10EqBlc7awitljeXycg+wg/b3HqeHcmCtr0beSNrSaSZu0ULYZzvCWj +njz5LWl5R2Amt/zPK0FAaQNWvc3swMU0GmLgFubzz9KAVEiWBaxoXM84cd8vuyVfVMB 6WVY9LwOVCfY6aE8r9SgvxLiWD3mbieSsbTu3IcRl5R2/+/mYopWzIIv0bdg/8X3TWal YlAZ0pr7sBeRDOFrQQPik5zipbkAWS3VG1K0C8L+aIoKhlwjnPKzPOFwaygOoOaIfhB/ YreQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yNDQAJFSLJLfThTJNbvSt9PeMOmz29jO4MB8fgsGzuk=; b=qLzC3dvp2xpZIwl3XPWQmQGFyPv05WMR0QFcM/rb/ybFzTysdLCzPqh0Ait6ztK92B 0qjmlKM9NWo3FhoPqywT2iPU03+LVwqxdnsHEaCxmwKFJ9RZaH3b9QT4RWPIt9WE30be 6E0d0++b6N9Hg4F80FrZ2Xj6/NLX7nDqku7e6acDnaAMTIjLB5gn52jPUSbEBEDkViNs Y3GhgATmjlo5W35dv7PqBVfzDO2jZ1DRsWjTH9FhTx0VTr8hEQnyQ9kALrJImxMOwBqI 6/M7d02UgYDHCvvRNYWYNurdZs6YGSU3eootZaTRDQdVL4A3Ru9chWr4KUe32FfpDtdQ R1pg== X-Gm-Message-State: AOAM5320QX6IgMbzQJfy5IyIq2cTRJ82xkeLcImX72sSBXWYp5ze/J9S KU6xlA4shc6IegcUGjCWdo2YPQdc8CCDIBCPwX8= X-Google-Smtp-Source: ABdhPJw0MS94YmH30OEhljXEK+RsU8HRDjB/Xfc1ODsadvJWNP3IIVtBaQcg1cJKl4O56fx1OFJTZYmeX3nGYSfkEoQ= X-Received: by 2002:a4a:ea4e:0:b0:333:3026:ca4f with SMTP id j14-20020a4aea4e000000b003333026ca4fmr2477358ooe.28.1650038649735; Fri, 15 Apr 2022 09:04:09 -0700 (PDT) MIME-Version: 1.0 References: <20220409194548.806763-1-david@tethera.net> <20220409194548.806763-3-david@tethera.net> <877d7qoa4f.fsf@tethera.net> In-Reply-To: <877d7qoa4f.fsf@tethera.net> From: Michael J Gruber Date: Fri, 15 Apr 2022 18:03:58 +0200 Message-ID: Subject: Re: [PATCH v2 2/2] lib: add sexp: prefix to Xapian (infix) query parser. To: David Bremner Message-ID-Hash: SEA462AHC7L5DFVRSGSOU5MGKYG4AWSO X-Message-ID-Hash: SEA462AHC7L5DFVRSGSOU5MGKYG4AWSO X-MailFrom: michaeljgruber@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: notmuch@notmuchmail.org X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: multipart/mixed; boundary="===============7687521342660408314==" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650039251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=gDt0vyTZVD2bszK5ZYDC9FciXTfM7F1C0J3YXLXuuS0=; b=YOvcsVIEFrDn2aB1bAE4aKIP3zmxKzLZ8cgfp2Q0LC1PuQcSo3JbugwtavRQ8NTBYEq64c rYs0m0McBncxT8bYvme+MTrcD3H0JaRkXtKmcsy8WsxAmIFGRj6NMBEDGNbxYb/21MEmh3 6yUUJGjQFOmubFuscOF2FfUH2sNhx++5vg2zBeSHgHIkyW9BJ4E1HLiZOE6gfu/eAToEZ4 hid6lAk97cGCGzA9fBjrzTbbKqpFpv5c09QzG9uiy8ybczhmlvTUh0mdG2oTcG2xU7drsn TOIzoNbOelVTF2woe5wO2P78CnPhHP9uNZO8pSkU99d7busBA4KZ8n8NZ7tMjQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650039251; a=rsa-sha256; cv=none; b=to5BnrBnLE8YxpED9UHSbIkxq+yI+syTSBI9Vtm167Z/xn33tqCgLaieT433S7h9LiKcBu 2whg8gri2At/IeMdc2/bAGI+i7V3yOI7V6Q5YZdSybGmdmRvrE6hJS64cd4lTR86uRuy8t Nma9ScgVviIDRxrH/l6u9ez/WVfz2j3ZXN4+mCPgYn0UVyOXV7/slcvBbUbZV6PQigl8iU y1KRYj0PLv7DLVKyicc7UtdB84IxpTVYDJDeUm6ZCkLNxN6RZlZsVLNvzRT+zzr4Z2jhaQ LrcwWNVWD5CDNoUpk2ab/93+IcIAqi2xnGWVt3SMOpnuF2ij2L+paGh83EUoPQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20210112 header.b=m5asjieJ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 13.81 X-Spam: Yes Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20210112 header.b=m5asjieJ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: C597C13CA1 X-Spam-Score: 13.81 X-Migadu-Spam: Yes X-Migadu-Scanner: scn0.migadu.com X-TUID: +7MnuhNzKcr0 --===============7687521342660408314== Content-Type: multipart/alternative; boundary="0000000000009554a005dcb38fb4" --0000000000009554a005dcb38fb4 Content-Type: text/plain; charset="UTF-8" This breaks builds if you don't have sfexp, unfortunately. (And since there is no sfsexp release with the recent fixes, there is no sfsexp in Fedora, for example.) Not declaring _notmuch_sexp_string_to_xapian_query() twice in lib/database-private.h (once unconditionally, once depending on HAVE_SFSEXP) may be part of the fix, as well as guarding it in lib/query.cc. But I'm not sure what SexpFieldProcessor::operator() should do when sfsexp is not available - throw a Xapian error? Am Fr., 15. Apr. 2022 um 13:32 Uhr schrieb David Bremner : > David Bremner writes: > > > This is analogous to the "infix" prefix provided by the s-expression > > based query parser. > > series applied to master. > _______________________________________________ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-leave@notmuchmail.org > --0000000000009554a005dcb38fb4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This breaks builds if you don't have sfexp, unfortunat= ely. (And since there is no sfsexp release with the recent fixes, there is = no sfsexp=C2=A0in Fedora, for example.)

Not declaring _n= otmuch_sexp_string_to_xapian_query() twice in=C2=A0lib/database-private.h (= once unconditionally, once depending on HAVE_SFSEXP) may be part of the fix= ,=C2=A0as well as guarding it in lib/query.cc. But I'm not sure what=C2= =A0SexpFieldProcessor::operator() should do when sfsexp=C2=A0is not availab= le - throw a Xapian error?

Am Fr., 15. Apr. 2022 um 13:32=C2=A0Uhr= schrieb David Bremner <david@tethe= ra.net>:
= David Bremner <da= vid@tethera.net> writes:

> This is analogous to the "infix" prefix provided by the s-ex= pression
> based query parser.

series applied to master.
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org
--0000000000009554a005dcb38fb4-- --===============7687521342660408314== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============7687521342660408314==--