From: Michael J Gruber <michaeljgruber+grubix+git@gmail.com>
To: David Bremner <david@tethera.net>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH v2 2/2] lib: add sexp: prefix to Xapian (infix) query parser.
Date: Fri, 15 Apr 2022 18:03:58 +0200 [thread overview]
Message-ID: <CAA19uiRpGpTTPsoMRJtaUO8077gh6MyGYgSagRH-h4ewQBa9Gg@mail.gmail.com> (raw)
In-Reply-To: <877d7qoa4f.fsf@tethera.net>
[-- Attachment #1.1: Type: text/plain, Size: 904 bytes --]
This breaks builds if you don't have sfexp, unfortunately. (And since there
is no sfsexp release with the recent fixes, there is no sfsexp in Fedora,
for example.)
Not declaring _notmuch_sexp_string_to_xapian_query() twice
in lib/database-private.h (once unconditionally, once depending on
HAVE_SFSEXP) may be part of the fix, as well as guarding it in
lib/query.cc. But I'm not sure what SexpFieldProcessor::operator() should
do when sfsexp is not available - throw a Xapian error?
Am Fr., 15. Apr. 2022 um 13:32 Uhr schrieb David Bremner <david@tethera.net
>:
> David Bremner <david@tethera.net> writes:
>
> > This is analogous to the "infix" prefix provided by the s-expression
> > based query parser.
>
> series applied to master.
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org
>
[-- Attachment #1.2: Type: text/html, Size: 1454 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2022-04-15 16:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 19:45 v2 allow sexp queries in infix parser David Bremner
2022-04-09 19:45 ` [PATCH v2 1/2] test/sexp: add test for and of stemmed terms David Bremner
2022-04-09 19:45 ` [PATCH v2 2/2] lib: add sexp: prefix to Xapian (infix) query parser David Bremner
2022-04-15 11:32 ` David Bremner
2022-04-15 16:03 ` Michael J Gruber [this message]
2022-04-15 16:23 ` [PATCH] fix build without sfsexp michaeljgruber+grubix+git
2022-04-15 17:31 ` David Bremner
2022-04-15 17:03 ` [PATCH] lib: don't compile sexp: prefix if no sfsexp library David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA19uiRpGpTTPsoMRJtaUO8077gh6MyGYgSagRH-h4ewQBa9Gg@mail.gmail.com \
--to=michaeljgruber+grubix+git@gmail.com \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).