From: Michael J Gruber <git@grubix.eu>
To: Tomi Ollila <tomi.ollila@iki.fi>
Cc: notmuch@notmuchmail.org
Subject: Re: Test suite timing issues?
Date: Sat, 12 Feb 2022 21:54:52 +0100 [thread overview]
Message-ID: <CAA19uiRDdb=Krfi=O9L_wvvwB2eyNDpuvQdBpk_jOk6zJ+9+8g@mail.gmail.com> (raw)
In-Reply-To: <m24k53g6fe.fsf@guru.guru-group.fi>
[-- Attachment #1.1: Type: text/plain, Size: 1577 bytes --]
Am Sa., 12. Feb. 2022 um 21:45 Uhr schrieb Tomi Ollila <tomi.ollila@iki.fi>:
> On Sat, Feb 12 2022, David Bremner wrote:
>
> > Tomi Ollila <tomi.ollila@iki.fi> writes:
> >
> >> On Sat, Feb 12 2022, Michael J. Gruber wrote:
> >>
> >> Only thing that came into mind are directory timestamps... if directory
> >> (m)time is same as before notmuch will not scan it for files...
> >>
> >> ... following that if the granularity of directory timestamp were 1
> second,
> >> then it could easily happen than first one new message is not seen, and
> >> next time there is one extra message to be see...
> >
> > What do you think about adding --full-scan to the notmuch-new invocation
> > in add_message? It doesn't make any tests fail and is about the same
> > speed. I need to do a few more trials, but first time through it was
> > actually faster (!), maybe because the cache is hot
>
> Does such a change hide "buggy" functionality ?
>
> Or do we consider notmuch new buggy if it does not notice all new messages
> arrived every time ?
>
>
The timestamping sounds like a perfect explanation of what I've been
seeing. Unfortunately, I can't reproduce the issue "reliably" (with a
certain probability), and so if everything succeeds with --full-scan 10
times it still does not mean much.
As I understand, notmuch new without --full-sync may have issues when the
time resolution is too low (or operations too fast) and will pick a message
on the next run, so it's not really buggy - it uses a shortcut that may be
too quick but does not loose messages in the long run.
Michael
>
>
[-- Attachment #1.2: Type: text/html, Size: 2321 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2022-02-12 20:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 13:55 Test suite timing issues? Michael J Gruber
2022-02-11 14:04 ` Michael J Gruber
2022-02-12 0:03 ` David Bremner
2022-02-12 13:32 ` Michael J Gruber
2022-02-12 14:30 ` David Bremner
2022-02-12 15:06 ` Tomi Ollila
2022-02-12 15:29 ` David Bremner
2022-02-12 19:40 ` David Bremner
2022-02-12 20:45 ` Tomi Ollila
2022-02-12 20:54 ` Michael J Gruber [this message]
2022-02-12 21:09 ` David Bremner
2022-02-12 21:53 ` Michael J Gruber
2022-02-12 22:14 ` Tomi Ollila
2022-02-13 8:29 ` Tomi Ollila
2022-02-14 14:01 ` David Bremner
2022-02-14 14:48 ` Tomi Ollila
2022-02-14 22:53 ` Tomi Ollila
2022-02-15 8:51 ` Michael J Gruber
2022-02-15 15:18 ` Michael J Gruber
2022-02-16 9:52 ` [PATCH] test: allow to use --full-sync Michael J Gruber
2022-02-16 13:04 ` David Bremner
2022-02-16 15:53 ` Michael J Gruber
2022-02-16 21:17 ` Tomi Ollila
2022-02-16 22:01 ` Tomi Ollila
2022-02-17 12:26 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA19uiRDdb=Krfi=O9L_wvvwB2eyNDpuvQdBpk_jOk6zJ+9+8g@mail.gmail.com' \
--to=git@grubix.eu \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).