From: Michael J Gruber <michaeljgruber+grubix+git@gmail.com>
To: David Bremner <david@tethera.net>
Cc: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH 4/4] CLI/git: replace calls to notmuch-search with database access
Date: Sat, 9 Jul 2022 21:35:21 +0200 [thread overview]
Message-ID: <CAA19uiR-chWxpgS=uR0VzwBjbPgL98_k9NsfDcaBMm8QgPnDEw@mail.gmail.com> (raw)
In-Reply-To: <877d4oykuy.fsf@tethera.net>
Am Do., 7. Juli 2022 um 17:59 Uhr schrieb David Bremner <david@tethera.net>:
>
> Tomi Ollila <tomi.ollila@iki.fi> writes:
>
> > On Sun, Jul 03 2022, David Bremner wrote:
> >
> > I've trying to think if there were a way to somehow run only one notmuch
> > command instead of notmuch search on all maeby-deleted files -- or
> > alternatively attempt to load python bindings and in case of failure use
> > the notmuch-search methid...
> >
>
> We could run one notmuch-dump command to get a list of the message-ids
> in the database, and build a dictionary in memory. Might be a bit slow?
> Here it would take 10-15s just do the dump. But certainly faster than
> 500K execs of notmuch search
When I first saw that `notmuch-git` is implemented in python and calls
out to `notmuch search` I wondered: Why doesn't it use the python
bindings?
I don't think "building the project partially and installing by
copying parts somewhere" is a use case that the design implementation
has to cater for, especially if this incurs performance penalties.
Scripting around `notmuch dump` does not make things better.
I do understand that you want lean dependencies server side, but
having python there isn't really uncommon, is it?
If building and installing from git via `make install` is too much of
a hassle we should probably work on reducing the hassle ;)
Cheers
Michael
next prev parent reply other threads:[~2022-07-09 19:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-03 15:10 performance improvements for notmuch git checkout David Bremner
2022-07-03 15:11 ` [PATCH 1/4] debian: add git as a build-dependency, for the test suite David Bremner
2022-07-07 10:30 ` David Bremner
2022-07-03 15:11 ` [PATCH 2/4] perf-test: add tests for notmuch-git David Bremner
2022-07-05 16:40 ` Tomi Ollila
2022-07-07 9:47 ` David Bremner
2022-07-03 15:11 ` [PATCH 3/4] CLI/git: current cache contents (file list) of index David Bremner
2022-07-03 15:11 ` [PATCH 4/4] CLI/git: replace calls to notmuch-search with database access David Bremner
2022-07-07 14:51 ` Tomi Ollila
2022-07-07 15:59 ` David Bremner
2022-07-09 19:35 ` Michael J Gruber [this message]
2022-07-15 14:43 ` [PATCH v2] CLI/git: opportunistically use bindings to check for known messages David Bremner
2022-07-16 19:23 ` Tomi Ollila
2022-07-17 0:51 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA19uiR-chWxpgS=uR0VzwBjbPgL98_k9NsfDcaBMm8QgPnDEw@mail.gmail.com' \
--to=michaeljgruber+grubix+git@gmail.com \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).