From: Austin Clements <amdragon@mit.edu>
To: Jameson Rollins <jrollins@finestructure.net>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] use custom-face-edit value-type in notmuch-search-line-faces
Date: Sun, 27 Mar 2011 22:57:46 -0400 [thread overview]
Message-ID: <BANLkTimiR25ic=t0aEGnrn5bNBeuuzx+pA@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1102 bytes --]
On Sun, Mar 27, 2011 at 1:26 AM, Jameson Rollins <jrollins@finestructure.net>
wrote:
> On Sat, 26 Mar 2011 22:16:32 -0700, Jameson Graef Rollins <
jrollins@finestructure.net> wrote:
>> This enables the proper face customization UI for
>> notmuch-search-line-faces.
>
> Hey, folks. amdragon was the one who figured out that custom-face-edit
> was the correct value-type to use to get the face customization ui for
> the notmuch-search-line-faces list. However, he seems to think this
> might not be the right solution. Austin: care to comment?
My concern is that it's unclear if the custom-face-edit widget is considered
a public interface, or if it's internal to customize and thus could change
at any time. These things are always a bit murky in Emacs. custom-face-edit
has been around for a few major versions, though it only recently (somewhere
between Emacs 22 and 23) became embeddable in a customize widget like this.
We should just ask on an Emacs mailing list if this is okay, or if it will
break catastrophically and without warning at some point (or if there's a
more official solution).
[-- Attachment #2: Type: text/html, Size: 1308 bytes --]
next reply other threads:[~2011-03-28 2:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 2:57 Austin Clements [this message]
2011-03-28 4:42 ` [PATCH] use custom-face-edit value-type in notmuch-search-line-faces Jameson Graef Rollins
-- strict thread matches above, loose matches on Subject: below --
2011-03-27 5:16 Jameson Graef Rollins
2011-03-27 5:26 ` Jameson Rollins
2011-04-19 14:46 ` Pieter Praet
2011-04-25 20:52 ` Carl Worth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTimiR25ic=t0aEGnrn5bNBeuuzx+pA@mail.gmail.com' \
--to=amdragon@mit.edu \
--cc=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).