From: Austin Clements <amdragon@mit.edu>
To: Florian Friesdorf <flo@chaoflow.net>
Cc: notmuch@notmuchmail.org, Andreas Amann <a.amann@ucc.ie>
Subject: Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search
Date: Sun, 8 May 2011 18:02:00 -0400 [thread overview]
Message-ID: <BANLkTi=zkF5UtGPc69O06ZEaaCes-52y4w@mail.gmail.com> (raw)
In-Reply-To: <877ha06epi.fsf@eve.chaoflow.net>
On Sun, May 8, 2011 at 5:54 PM, Florian Friesdorf <flo@chaoflow.net> wrote:
> On Sun, 8 May 2011 17:40:54 -0400, Austin Clements <amdragon@mit.edu> wrote:
>> Also, existing code conventionally uses a variable named "local"
>> for function-level talloc contexts such as your ctx_quote.
>
> In notmuch-search.c there is no variable named "local", in the other
> functions its also named ctx_quote. Should I rename all ctx_quote to
> "local"?
Huh, sure enough. Looks like the library uses "local" consistently,
but the CLI uses ctx_quote multiple times and "local" appears only
once, so, yeah, stick with ctx_quote.
next prev parent reply other threads:[~2011-05-08 22:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 23:17 [PATCH] search --format=sanitized_text Florian Friesdorf
2011-05-06 23:17 ` [PATCH] implement search --format=sanitized_text + emacs UI to use it Florian Friesdorf
2011-05-06 23:55 ` Austin Clements
2011-05-07 0:15 ` Florian Friesdorf
2011-05-07 1:06 ` Jameson Graef Rollins
2011-05-07 9:14 ` Pieter Praet
2011-05-07 9:25 ` Pieter Praet
2011-05-08 21:14 ` [PATCH] sanitize notmuch-search output - rewrapped Florian Friesdorf
2011-05-08 21:14 ` [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search Florian Friesdorf
2011-05-08 21:40 ` Austin Clements
2011-05-08 21:54 ` Florian Friesdorf
2011-05-08 22:02 ` Austin Clements [this message]
2011-05-08 23:12 ` [PATCH] sanitize notmuch-search output - rewrapped Florian Friesdorf
2011-05-08 23:16 ` Florian Friesdorf
2011-05-08 23:13 ` [PATCH 1/2] style fixes Florian Friesdorf
2011-05-08 23:13 ` [PATCH 2/2] test for sanitized notmuch-search output Florian Friesdorf
2011-05-08 23:58 ` [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search Jameson Graef Rollins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=zkF5UtGPc69O06ZEaaCes-52y4w@mail.gmail.com' \
--to=amdragon@mit.edu \
--cc=a.amann@ucc.ie \
--cc=flo@chaoflow.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).