From: Austin Clements <amdragon@mit.edu>
To: Mark Anderson <ma.skies@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] test:Improve test behaviors when --root is used
Date: Mon, 27 Jun 2011 16:50:47 -0400 [thread overview]
Message-ID: <BANLkTi=bXR+ors+YZH8yNkU7ZXEOvrXwDw@mail.gmail.com> (raw)
In-Reply-To: <87vcvrw91f.fsf@gmail.com>
This looks great (modulo one bug, below). I've wanted to run the
tests on tmpfs before, but was too lazy to actually fix the tests.
Given how easy it is to accidentally use "..", I wonder if there's a
way to force people to use $TEST_DIRECTORY?
On Mon, Jun 27, 2011 at 12:09 PM, Mark Anderson <ma.skies@gmail.com> wrote:
> --- a/test/symbol-hiding
> +++ b/test/symbol-hiding
> @@ -12,13 +12,13 @@ test_description='exception symbol hiding'
> . ./test-lib.sh
>
> run_test(){
> - result=$(LD_LIBRARY_PATH=../../lib ./symbol-test 2>&1)
> + result=$(LD_LIBRARY_PATH=$TEST_DIRECTORY/../../lib ./symbol-test 2>&1)
Did you mean $TEST_DIRECTORY/../lib?
next prev parent reply other threads:[~2011-06-27 20:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 16:09 [PATCH] test:Improve test behaviors when --root is used Mark Anderson
2011-06-27 20:50 ` Austin Clements [this message]
2011-06-27 23:03 ` Mark Anderson
2011-06-28 20:28 ` Carl Worth
2011-06-28 21:25 ` [PATCH v2] " Mark Anderson
2011-06-28 22:11 ` [PATCH v3] " Mark Anderson
2011-06-28 23:03 ` Carl Worth
2011-06-29 20:20 ` Pieter Praet
2011-06-29 20:23 ` [PATCH] test: revert non-intentional changes introduced in eb4cf465 Pieter Praet
2011-06-29 21:23 ` Carl Worth
2011-06-28 6:36 ` [PATCH] test:Improve test behaviors when --root is used Pieter Praet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=bXR+ors+YZH8yNkU7ZXEOvrXwDw@mail.gmail.com' \
--to=amdragon@mit.edu \
--cc=ma.skies@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).