Filtering out replies to a patch series

Filtering out replies to a patch series

[Amit Kucheria]

Hi,

I am wondering how developers on this list handle the case of grabbing
a patch series posted to the list and using something like git-am to
apply it to their local trees.

Several patches in the series could have replies to them and hence
they need to be filtered out.

e.g. I use notmuch show --output=mbox thread:000000000000eb4e to get
the basic series. But I'd appreciate any tips on filtering out the
replies.

Cheers,
Amit

Re: Filtering out replies to a patch series

[Amit Kucheria]

On Fri, Apr 1, 2011 at 11:47 AM, Amit Kucheria
<amit.kucheria@verdurent.com> wrote:
> Hi,
>
> I am wondering how developers on this list handle the case of grabbing
> a patch series posted to the list and using something like git-am to
> apply it to their local trees.
>
> Several patches in the series could have replies to them and hence
> they need to be filtered out.
>
> e.g. I use notmuch show --output=mbox thread:000000000000eb4e to get
> the basic series. But I'd appreciate any tips on filtering out the
> replies.

Aargh, that was meant to be notmuch show --format=mbox thread:000000000000eb4e

/Amit

Re: Filtering out replies to a patch series

[Pieter Praet]

On Fri, 1 Apr 2011 11:47:25 +0300, Amit Kucheria <amit.kucheria@verdurent.com> wrote:
> Hi,
> 
> I am wondering how developers on this list handle the case of grabbing
> a patch series posted to the list and using something like git-am to
> apply it to their local trees.

See id:"m2vd3p3u78.fsf@kcals.maillard.im"

> Several patches in the series could have replies to them and hence
> they need to be filtered out.
> 
> e.g. I use notmuch show --output=mbox thread:000000000000eb4e to get
> the basic series. But I'd appreciate any tips on filtering out the
> replies.

Something like this might work:

  noreplieskthxbye() {
      thread_id=${1}
      target_dir=/tmp/${thread_id}
      test -d ${target_dir} && echo "Patch queue dirty. Remove ${target_dir}" && return 1
      mkdir -p ${target_dir}
      notmuch show --format=mbox ${thread_id} | git mailsplit -o${target_dir}
      grep -l "^diff --git" ${target_dir}/* | xargs git am -3
      rm -rf ${target_dir} # "Danger, Will Robinson!"
  }

  noreplieskthxbye thread:000000000000eb4e

But I'd be suprised beyond belief if there weren't a *sane* way to do
this. I might also need some coffee first...

> Cheers,
> Amit
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Peace

-Pieter

Re: Filtering out replies to a patch series

[Amit Kucheria]

On Mon, Apr 18, 2011 at 9:57 AM, Pieter Praet <pieter@praet.org> wrote:
> On Fri, 1 Apr 2011 11:47:25 +0300, Amit Kucheria <amit.kucheria@verdurent.com> wrote:
>> Hi,
>>
>> I am wondering how developers on this list handle the case of grabbing
>> a patch series posted to the list and using something like git-am to
>> apply it to their local trees.
>
> See id:"m2vd3p3u78.fsf@kcals.maillard.im"
>
>> Several patches in the series could have replies to them and hence
>> they need to be filtered out.
>>
>> e.g. I use notmuch show --output=mbox thread:000000000000eb4e to get
>> the basic series. But I'd appreciate any tips on filtering out the
>> replies.
>
> Something like this might work:
>
>  noreplieskthxbye() {
>      thread_id=${1}
>      target_dir=/tmp/${thread_id}
>      test -d ${target_dir} && echo "Patch queue dirty. Remove ${target_dir}" && return 1
>      mkdir -p ${target_dir}
>      notmuch show --format=mbox ${thread_id} | git mailsplit -o${target_dir}
>      grep -l "^diff --git" ${target_dir}/* | xargs git am -3
>      rm -rf ${target_dir} # "Danger, Will Robinson!"
>  }
>
>  noreplieskthxbye thread:000000000000eb4e
>
> But I'd be suprised beyond belief if there weren't a *sane* way to do
> this. I might also need some coffee first...

I haven't found a 'sane way' yet. Your scripting hack looks like a
good way to start though.

Re: Filtering out replies to a patch series

[Carl Worth]

[-- Attachment #1: Type: text/plain, Size: 1331 bytes --]

On Fri, 1 Apr 2011 11:47:25 +0300, Amit Kucheria <amit.kucheria@verdurent.com> wrote:
> Several patches in the series could have replies to them and hence
> they need to be filtered out.

I think I haven't run into this problem since when there's a reply, (on
this list at least), it's often of the form "please fix up this issue or
another" which then results in a subsequent mail with a new patch
series.

So I've been getting by with:

	| (cd ~/src/notmuch; git am -3)

And I think that "git am" probably handles an erroneous reply fairly
smoothly here, (gives "patch did not apply" and user does "git rebase
--continue" probably?).

Meanwhile, I have friends and co-workers that live within the world of
the Linux-kernel mailing list. And that world has a culture where people
reply with things like:

	Signed-off-by: Elite Hacker <elite@example.com>
or:
	Reviewed-by: Quality Coder <qc@example.com>

And it would be awfully convenient to have an easy mechanism for the
right thing to happen with replies like this, (which is that lines like
the above should be added to the commit message of the message above).

It would probably make sense for any extra smarts along these lines to
be implemented in "git am" rather than in anything in notmuch I think.

-Carl

-- 
carl.d.worth@intel.com

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]