unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Ali Polatel <polatel@gmail.com>
To: David Bremner <david@tethera.net>
Cc: Ali Polatel <alip@exherbo.org>,
	Notmuch Mailing List <notmuch@notmuchmail.org>,
	Austin Clements <amdragon@MIT.EDU>
Subject: [PATCH v3 1/2] lib: destroy message object after message removal
Date: Tue,  4 Oct 2011 08:06:08 +0300	[thread overview]
Message-ID: <9b3f16ce715d2371224955bc5b6f948eaa4ee325.1317704225.git.alip@exherbo.org> (raw)
In-Reply-To: <cover.1317704225.git.alip@exherbo.org>
In-Reply-To: <cover.1317704225.git.alip@exherbo.org>

From: Ali Polatel <alip@exherbo.org>

notmuch_database_remove_message() must call notmuch_message_destroy()
once it is done handling message removal.
---
 lib/database.cc |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/lib/database.cc b/lib/database.cc
index 9299c8d..d43e114 100644
--- a/lib/database.cc
+++ b/lib/database.cc
@@ -1769,6 +1769,8 @@ notmuch_database_remove_message (notmuch_database_t *notmuch,
 		_notmuch_message_delete (message);
 	    else if (status == NOTMUCH_STATUS_DUPLICATE_MESSAGE_ID)
 		_notmuch_message_sync (message);
+
+	    notmuch_message_destroy (message);
     }
 
     return status;
-- 
1.7.6.1

  reply	other threads:[~2011-10-04  5:06 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-27 13:25 Concerns regarding some library functions Ali Polatel
2011-09-27 16:59 ` David Bremner
2011-09-27 22:46   ` Austin Clements
2011-09-28  7:53     ` Ali Polatel
2011-09-29 14:51       ` Austin Clements
2011-09-29 19:59         ` David Bremner
2011-09-29 20:15           ` Austin Clements
2011-10-04 11:18             ` David Bremner
2011-10-04 13:40               ` Tomi Ollila
2011-10-04 19:36               ` libnotmuch SONAME bumped David Bremner
2011-09-30  6:47         ` Concerns regarding some library functions Ali Polatel
2011-10-01  8:12           ` [PATCH] lib: make find_message{,by_filename) report errors Ali Polatel
2011-10-01  8:12             ` Ali Polatel
2011-10-05 13:42               ` Sebastian Spaeth
2011-10-03 16:49             ` [PATCH v1 0/1] " Ali Polatel
2011-10-03 16:49               ` [PATCH v1 1/1] " Ali Polatel
2011-10-03 17:43                 ` Austin Clements
2011-10-03 20:38                   ` [PATCH v1 1/1] lib: make find_message{, by_filename) " Ali Polatel
2011-10-03 20:40                     ` [PATCH v2 0/2] Better error handling Ali Polatel
2011-10-03 20:40                       ` [PATCH v2 1/2] lib: destroy message object after message removal Ali Polatel
2011-10-03 20:40                       ` [PATCH v2 2/2] lib: make find_message{,by_filename) report errors Ali Polatel
2011-10-03 20:53                       ` [PATCH v2 0/2] Better error handling Ali Polatel
2011-10-03 21:03                       ` Austin Clements
2011-10-04  1:10             ` [PATCH] lib: make find_message{,by_filename) report errors David Bremner
2011-10-04  5:00               ` Ali Polatel
2011-10-04  5:06                 ` [PATCH v3 0/2] Better error handling Ali Polatel
2011-10-04  5:06                   ` Ali Polatel [this message]
2011-10-04  5:06                   ` [PATCH v3 2/2] lib: make find_message{,by_filename) report errors Ali Polatel
2011-10-04 10:43                   ` [PATCH v3 0/2] Better error handling David Bremner
2011-09-28 15:42 ` Concerns regarding some library functions Sebastian Spaeth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b3f16ce715d2371224955bc5b6f948eaa4ee325.1317704225.git.alip@exherbo.org \
    --to=polatel@gmail.com \
    --cc=alip@exherbo.org \
    --cc=amdragon@MIT.EDU \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).