unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: "W. Trevor King" <wking@tremily.us>
To: notmuch@notmuchmail.org
Cc: Tomi Ollila <tomi.ollila@iki.fi>
Subject: [PATCH v2 4/6] nmbug-status: Factor out header/footer context into a shared dict
Date: Sat, 31 May 2014 15:20:25 -0700	[thread overview]
Message-ID: <967d2f99ba4e4b17c8e73b879b9205e64e562448.1401574293.git.wking@tremily.us> (raw)
In-Reply-To: <cover.1401574293.git.wking@tremily.us>
In-Reply-To: <cover.1401574293.git.wking@tremily.us>

Rather than splitting this context into header-only and footer-only
groups, just dump it all in a shared dict.  This will make it easier
to eventually split the header/footer templates out of this script
(e.g. if we want to load them from the config file).
---
 devel/nmbug/nmbug-status | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/devel/nmbug/nmbug-status b/devel/nmbug/nmbug-status
index c92d268..b7c2f80 100755
--- a/devel/nmbug/nmbug-status
+++ b/devel/nmbug/nmbug-status
@@ -275,6 +275,14 @@ parser.add_argument('--get-query', help='get query for view',
 args = parser.parse_args()
 
 config = read_config(path=args.config)
+context = {
+    'date': datetime.datetime.utcnow(),
+    'title': config['meta']['title'],
+    'blurb': config['meta']['blurb'],
+    'encoding': _ENCODING,
+    'inter_message_padding': '0.25em',
+    'border_radius': '0.5em',
+    }
 
 _PAGES['text'] = Page()
 _PAGES['html'] = HtmlPage(
@@ -328,17 +336,13 @@ _PAGES['html'] = HtmlPage(
 {blurb}
 </p>
 <h3>Views</h3>
-'''.format(title=config['meta']['title'],
-           blurb=config['meta']['blurb'],
-           encoding=_ENCODING,
-           inter_message_padding='0.25em',
-           border_radius='0.5em'),
+'''.format(**context),
     footer='''
 <hr>
 <p>Generated: {date}
 </body>
 </html>
-'''.format(date=datetime.datetime.utcnow().date())
+'''.format(**context),
     )
 
 if args.list_views:
-- 
1.9.1.353.gc66d89d

  parent reply	other threads:[~2014-05-31 22:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-31 22:20 [PATCH v2 0/6] nmbug-status fixups from notmuch-to-html W. Trevor King
2014-05-31 22:20 ` [PATCH v2 1/6] Add explicit license information W. Trevor King
2014-05-31 22:20 ` [PATCH v2 2/6] Add a docstring describing the program W. Trevor King
2014-05-31 22:20 ` [PATCH v2 3/6] Move the generated date from the top of the page to the footer W. Trevor King
2014-05-31 22:20 ` W. Trevor King [this message]
2014-05-31 22:20 ` [PATCH v2 5/6] nmbug-status: Add the time to the footer's build-date W. Trevor King
2014-05-31 22:20 ` [PATCH v2 6/6] nmbug-status: Optionally load the header and footer templates from the config W. Trevor King
2014-06-01  8:22 ` [PATCH v2 0/6] nmbug-status fixups from notmuch-to-html Tomi Ollila
2014-07-15 23:12 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=967d2f99ba4e4b17c8e73b879b9205e64e562448.1401574293.git.wking@tremily.us \
    --to=wking@tremily.us \
    --cc=notmuch@notmuchmail.org \
    --cc=tomi.ollila@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).