[PATCH] Missing final semi-colon in .desktop's Categories.

[PATCH] Missing final semi-colon in .desktop's Categories.

[James Rowe]

"Those keys which have several values should have a semicolon as the trailing
character."
  -- http://standards.freedesktop.org/desktop-entry-spec/1.0/ar01s03.html

Signed-off-by: James Rowe <jnrowe@gmail.com>
---
 notmuch.desktop |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/notmuch.desktop b/notmuch.desktop
index d29dff6..819cd1e 100644
--- a/notmuch.desktop
+++ b/notmuch.desktop
@@ -4,4 +4,4 @@ Exec=emacs -f notmuch
 Icon=emblem-mail
 Terminal=false
 Type=Application
-Categories=Network;Email
+Categories=Network;Email;
-- 
1.6.4.4

Re: [PATCH] Missing final semi-colon in .desktop's Categories.

[Jeffrey Ollie]

Found the same problem on my own, only to minutes later catch up on
the backlog of patches in my email and find this!

On Sat, Nov 21, 2009 at 3:13 AM, James Rowe <jnrowe@gmail.com> wrote:
> "Those keys which have several values should have a semicolon as the trailing
> character."
>  -- http://standards.freedesktop.org/desktop-entry-spec/1.0/ar01s03.html
>
> Signed-off-by: James Rowe <jnrowe@gmail.com>

Reviewed-by: Jeffrey C. Ollie <jeff@ocjtech.us>

> ---
>  notmuch.desktop |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/notmuch.desktop b/notmuch.desktop
> index d29dff6..819cd1e 100644
> --- a/notmuch.desktop
> +++ b/notmuch.desktop
> @@ -4,4 +4,4 @@ Exec=emacs -f notmuch
>  Icon=emblem-mail
>  Terminal=false
>  Type=Application
> -Categories=Network;Email
> +Categories=Network;Email;
> --
> 1.6.4.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
>



-- 
Jeff Ollie

Re: [PATCH] Missing final semi-colon in .desktop's Categories.

[Carl Worth]

On Sun, 22 Nov 2009 01:07:49 -0600, Jeffrey Ollie <jeff@ocjtech.us> wrote:
> Found the same problem on my own, only to minutes later catch up on
> the backlog of patches in my email and find this!
...
> > Signed-off-by: James Rowe <jnrowe@gmail.com>
> 
> Reviewed-by: Jeffrey C. Ollie <jeff@ocjtech.us>

Much thanks, James and Jeffrey!

I always feel *much* more comfortable pushing a patch I haven't tested
personally if someone else has reviewed it.

-Carl