From: Jani Nikula <jani@nikula.org>
To: notmuch@notmuchmail.org, Rob Browning <rlb@defaultvalue.org>
Subject: [PATCH 1/3] cli: export function for illegal tag checking
Date: Sun, 23 Feb 2014 18:55:21 +0200 [thread overview]
Message-ID: <9143b898e9112f07988c2db2d50a57f8638a3082.1393174108.git.jani@nikula.org> (raw)
In-Reply-To: <cover.1393174108.git.jani@nikula.org>
In-Reply-To: <cover.1393174108.git.jani@nikula.org>
This lets us check for forbidden tags consistently across the cli. No
functional changes.
---
tag-util.c | 9 +--------
tag-util.h | 12 ++++++++++++
2 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/tag-util.c b/tag-util.c
index 3bde4097372a..e2d5b795acc3 100644
--- a/tag-util.c
+++ b/tag-util.c
@@ -31,14 +31,7 @@ line_error (tag_parse_status_t status,
return status;
}
-/*
- * Test tags for some forbidden cases.
- *
- * return: NULL if OK,
- * explanatory message otherwise.
- */
-
-static const char *
+const char *
illegal_tag (const char *tag, notmuch_bool_t remove)
{
diff --git a/tag-util.h b/tag-util.h
index 4628f1630ad6..8a4074ce168f 100644
--- a/tag-util.h
+++ b/tag-util.h
@@ -90,6 +90,18 @@ parse_tag_command_line (void *ctx, int argc, char **argv,
char **query_str, tag_op_list_t *ops);
/*
+ * Test tags for some forbidden cases.
+ *
+ * Relax the checks if 'remove' is true to allow removal of previously
+ * added forbidden tags.
+ *
+ * return: NULL if OK,
+ * explanatory message otherwise.
+ */
+const char *
+illegal_tag (const char *tag, notmuch_bool_t remove);
+
+/*
* Create an empty list of tag operations
*
* ctx is passed to talloc
--
1.8.5.3
next prev parent reply other threads:[~2014-02-23 16:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-23 2:29 [BUG] Putting "tags=;" into .notmuch-config will create empty tags Rob Browning
2014-02-23 16:55 ` [PATCH 0/3] check new.tags for invalid tags Jani Nikula
2014-02-23 16:55 ` Jani Nikula [this message]
2014-02-23 16:55 ` [PATCH 2/3] cli: make sure notmuch new and insert don't add " Jani Nikula
2014-02-23 16:55 ` [PATCH 3/3] test: add tests for invalid new.tags Jani Nikula
2014-02-23 18:21 ` [PATCH 0/3] check new.tags for invalid tags Tomi Ollila
2014-03-04 16:51 ` [PATCH] cli: add missing \n in error message Jani Nikula
2014-03-06 11:51 ` [PATCH 0/3] check new.tags for invalid tags David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9143b898e9112f07988c2db2d50a57f8638a3082.1393174108.git.jani@nikula.org \
--to=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
--cc=rlb@defaultvalue.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).