unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Jani Nikula <jani@nikula.org>
To: notmuch@notmuchmail.org
Subject: [PATCH v2 1/2] emacs: Fix notmuch-hello-tag-list-make-query defcustom
Date: Tue, 20 Dec 2011 21:53:13 +0200	[thread overview]
Message-ID: <8c69566692e6e7c36e3c3cfcfba2c1122e5c10b1.1324410479.git.jani@nikula.org> (raw)
In-Reply-To: <cover.1324410479.git.jani@nikula.org>
In-Reply-To: <cover.1324410479.git.jani@nikula.org>

It was not possible to define custom filters or filter functions because
the types were const. Remove const to allow editing.

Signed-off-by: Jani Nikula <jani@nikula.org>
---
 emacs/notmuch-hello.el |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index 81b2605..7dd0f85 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -86,8 +86,9 @@ Finally this can be a function that will be called for each tag and
 should return a filter for that tag, or nil to hide the tag."
   :type '(choice (const :tag "All messages" nil)
 		 (const :tag "Unread messages" "tag:unread")
-		 (const :tag "Custom filter" string)
-		 (const :tag "Custom filter function" function))
+		 (string :tag "Custom filter"
+			 :value "tag:unread")
+		 (function :tag "Custom filter function"))
   :group 'notmuch)
 
 (defcustom notmuch-hello-hide-tags nil
-- 
1.7.5.4

  reply	other threads:[~2011-12-20 19:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-23 19:03 [PATCH 1/2] emacs: Fix notmuch-hello-tag-list-make-query defcustom Jani Nikula
2011-09-23 19:03 ` [PATCH 2/2] emacs: Fix notmuch-mua-user-agent defcustom Jani Nikula
2011-12-16 12:31   ` Dmitry Kurochkin
2011-12-16 12:22 ` [PATCH 1/2] emacs: Fix notmuch-hello-tag-list-make-query defcustom Dmitry Kurochkin
2011-12-16 12:29   ` Dmitry Kurochkin
2011-12-20 19:53 ` [PATCH v2 0/2] emacs: trivial defcustom fixes Jani Nikula
2011-12-20 19:53   ` Jani Nikula [this message]
2011-12-22 11:34     ` [PATCH v2 1/2] emacs: Fix notmuch-hello-tag-list-make-query defcustom David Bremner
2011-12-20 19:53   ` [PATCH v2 2/2] emacs: Fix notmuch-mua-user-agent defcustom Jani Nikula
2011-12-21  8:51   ` [PATCH v2 0/2] emacs: trivial defcustom fixes David Edmondson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c69566692e6e7c36e3c3cfcfba2c1122e5c10b1.1324410479.git.jani@nikula.org \
    --to=jani@nikula.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).