From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id EEC6A431FAE for ; Thu, 26 Nov 2009 13:21:52 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Gpi5eBc7WVNB for ; Thu, 26 Nov 2009 13:21:52 -0800 (PST) Received: from mail-bw0-f224.google.com (mail-bw0-f224.google.com [209.85.218.224]) by olra.theworths.org (Postfix) with ESMTP id 91001431FBC for ; Thu, 26 Nov 2009 13:21:52 -0800 (PST) Received: by bwz24 with SMTP id 24so840369bwz.30 for ; Thu, 26 Nov 2009 13:21:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:from:to:cc:subject :in-reply-to:references:date:message-id:mime-version:content-type; bh=P4sQvcLYOUk0BUbvbFa+3aCaewGXMSPPoqrPgfc2r4o=; b=JRD+XWKpLcCmxEY2lU+QXCzHUQDO0GevWwt6WsAO154UR8s/iQ5+nPoaHAP+0IWoO7 +9rTf0uiD5fFYZOxo46OJ1dlRgqVrR5HkDFiZRU+982fXGaENtE4leuxU/EKJNuwtWfe S5ZsitBa5ON0z9DMB0JwNspmVOqiQNEhb1l3A= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; b=hz+XV7zIoeYCe6gg5qyurYV08wltn/5bC4P7kFB+vFQsC8ZgR2hrAitjk/J5LLY6Qa AfiVBR9TjNu6hhEIA1WcD+DqVl3/XzlgJ9vbkWctQh6B6+z/kz/AXzFKTXRqf6oSqFAX 3JpiQuDIaqOBuondHtRDTCaackiCXHO3ZI4Ec= Received: by 10.204.175.2 with SMTP id v2mr217689bkz.197.1259270510719; Thu, 26 Nov 2009 13:21:50 -0800 (PST) Received: from kunyang (vawpc43.ethz.ch [129.132.59.11]) by mx.google.com with ESMTPS id 2sm1398839fks.43.2009.11.26.13.21.48 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 26 Nov 2009 13:21:49 -0800 (PST) Sender: Jed Brown From: Jed Brown To: Carl Worth , Tassilo Horn , Mikhail Gusarov In-Reply-To: <87ljhtq98x.fsf@yoom.home.cworth.org> References: <87ws1hldmu.fsf@thinkpad.tsdh.de> <87einpl50j.fsf@thinkpad.tsdh.de> <87ljhxjq5i.fsf@vertex.dottedmag> <876391l2si.fsf@thinkpad.tsdh.de> <87vdh1472z.fsf@59A2.org> <871vjlrv8b.fsf@yoom.home.cworth.org> <873a41dtbu.fsf@59A2.org> <87ljhtq98x.fsf@yoom.home.cworth.org> Date: Thu, 26 Nov 2009 22:22:24 +0100 Message-ID: <87zl69c773.fsf@59A2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: notmuch@notmuchmail.org Subject: Re: Notmuch doesn't index new mails when mail location contains symlinks X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Nov 2009 21:21:53 -0000 On Thu, 26 Nov 2009 13:14:22 -0800, Carl Worth wrote: > Then I'm still being really dense here. The non-propagation of mtime is > the with actual directories. And the code is trying to do the right > thing for that. The stat() is correct, it's the check for the d_type field coming out of scandir(). 20:08 [ jedbrown ] cworth: I think there are two problems with symlinks. 20:08 [ jedbrown ] cworth: First, notmuch-new.c:152 checks path_mtime which is mtime for the current directory. 20:09 [ jedbrown ] cworth: Additionally, won't entry->d_type == DT_LNK for a symlink? 20:14 [ aneesh ] jedbrown, i already have a patch posted for that 20:15 [ aneesh ] 1259125104-18785-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com Jed