* [PATCH] emacs: Correct message/header/citation/signature hiding
@ 2010-04-26 10:17 David Edmondson
2010-04-26 15:09 ` Carl Worth
0 siblings, 1 reply; 2+ messages in thread
From: David Edmondson @ 2010-04-26 10:17 UTC (permalink / raw)
To: notmuch
Set `buffer-invisibility-spec' to `nil' (a list) if it is just `t'
before inserting any body parts, otherwise removing items from
`buffer-invisibility-spec' (which is what
`notmuch-show-headers-visible' and `notmuch-show-message-visible' do)
is a no-op and has no effect. This caused threads with only matching
messages to have those messages hidden initially because
`buffer-invisibility-spec' stayed `t'.
---
Carl, we need this fix before 0.3 is released. The bug has always
existed in the JSON based UI and is now exposed because previously
there was always a call to `add-to-invisibility-spec' (for the
headers), which transformed `buffer-invisiliblty-spec' from `t' to a
list. That doesn't always happen now (only calls to
`remove-from-invisibility-spec'), so the variable could get left as
`t'.
emacs/notmuch-show.el | 16 ++++++++++++++++
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index f958a30..f9d6c93 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -382,6 +382,22 @@ current buffer, if possible."
(headers-invis-spec (notmuch-show-make-symbol "header"))
(message-invis-spec (notmuch-show-make-symbol "message")))
+ ;; Set `buffer-invisibility-spec' to `nil' (a list), otherwise
+ ;; removing items from `buffer-invisibility-spec' (which is what
+ ;; `notmuch-show-headers-visible' and
+ ;; `notmuch-show-message-visible' do) is a no-op and has no
+ ;; effect. This caused threads with only matching messages to have
+ ;; those messages hidden initially because
+ ;; `buffer-invisibility-spec' stayed `t'.
+ ;;
+ ;; This needs to be set here (rather than just above the call to
+ ;; `notmuch-show-headers-visible') because some of the part
+ ;; rendering or body washing functions
+ ;; (e.g. `notmuch-wash-text/plain-citations') manipulate
+ ;; `buffer-invisibility-spec').
+ (when (eq buffer-invisibility-spec t)
+ (setq buffer-invisibility-spec nil))
+
(setq message-start (point-marker))
(notmuch-show-insert-headerline headers
--
1.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] emacs: Correct message/header/citation/signature hiding
2010-04-26 10:17 [PATCH] emacs: Correct message/header/citation/signature hiding David Edmondson
@ 2010-04-26 15:09 ` Carl Worth
0 siblings, 0 replies; 2+ messages in thread
From: Carl Worth @ 2010-04-26 15:09 UTC (permalink / raw)
To: David Edmondson, notmuch
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
On Mon, 26 Apr 2010 11:17:11 +0100, David Edmondson <dme@dme.org> wrote:
> Set `buffer-invisibility-spec' to `nil' (a list) if it is just `t'
> before inserting any body parts, otherwise removing items from
> `buffer-invisibility-spec' (which is what
> `notmuch-show-headers-visible' and `notmuch-show-message-visible' do)
> is a no-op and has no effect. This caused threads with only matching
> messages to have those messages hidden initially because
> `buffer-invisibility-spec' stayed `t'.
Thanks for the regression fix, David! You've done a great job ensuring
that our 0.3 release will ready today. And I appreciate that.
> Carl, we need this fix before 0.3 is released.
Pushed now. It's quite nice to have this bug gone.
-Carl
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-26 15:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-26 10:17 [PATCH] emacs: Correct message/header/citation/signature hiding David Edmondson
2010-04-26 15:09 ` Carl Worth
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).