From: David Edmondson <dme@dme.org>
To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Do not color non-matching authors by tag
Date: Thu, 04 Nov 2010 14:45:33 +0000 [thread overview]
Message-ID: <87zktp2lma.fsf@ut.hh.sledj.net> (raw)
In-Reply-To: <87vd4djhy2.fsf@steelpick.2x.cz>
On Thu, 04 Nov 2010 15:12:53 +0100, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> > Michal, was this addressed by the patch that Carl recently merged?
> > (Commit f99ad42da03afd638bfdfdea92d1cbdd3b510b8f in my copy of the
> > repository.)
>
> Unfortunately not. In your patch, the overlay changes the color/face of the
> whole line while my patch change the color/face of all parts of the line
> except for non-matching authors. With my patch non-matched autors were
I understand now.
This seems somewhat like a policy decision, though. If I indicate that I
want the foreground text for a particular line to be red, should the
formatting of non-matching authors override that?
(My own approach has been to have `notmuch-search-line-faces' always
specify a background colour whereas
`notmuch-search-non-matching-authors' (or any of the columnar faces)
specify a foreground colour and/or slant.)
next prev parent reply other threads:[~2010-11-04 14:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 5:42 [PATCH] emacs: Do not color non-matching authors by tag Michal Sojka
2010-11-04 13:55 ` David Edmondson
2010-11-04 14:12 ` Michal Sojka
2010-11-04 14:45 ` David Edmondson [this message]
2010-11-05 8:10 ` Michal Sojka
2010-11-05 8:17 ` Michal Sojka
2010-11-05 8:55 ` David Edmondson
2010-11-05 11:42 ` Jameson Rollins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zktp2lma.fsf@ut.hh.sledj.net \
--to=dme@dme.org \
--cc=notmuch@notmuchmail.org \
--cc=sojkam1@fel.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).