From: Sebastian Spaeth <Sebastian@SSpaeth.de>
To: Austin Clements <amdragon@mit.edu>, Carl Worth <cworth@cworth.org>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 1/3] new: Do not defer maildir flag synchronization during the first run
Date: Fri, 28 Jan 2011 09:51:29 +0100 [thread overview]
Message-ID: <87zkql76ni.fsf@SSpaeth.de> (raw)
In-Reply-To: <AANLkTin8DdhHU7JRnobxZQGWadD0VH2_HKLx4tPWq4YG@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 779 bytes --]
On Thu, 27 Jan 2011 19:08:38 -0500, Austin Clements <amdragon@mit.edu> wrote:
> I added a "notmuch_database_remove_message_get" to the public API that's
> just like "notmuch_database_remove_message" except that it also returns a
> notmuch_message_t if other instances of the message still exist. It feels
> clunky to have two almost identical variants of this function. Is this the
> preferred way to change the public API? Or should I just add the argument
> to the existing function and fix the other three calls to it?
Just adding an argument to the public API without library version bump would
break my python bindings. So if we modify the public API, I would prefer
if we rename the function and remove the old one completely. That I
could detect at least.
Sebastian
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2011-01-28 8:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 0:08 [PATCH 1/3] new: Do not defer maildir flag synchronization during the first run Austin Clements
2011-01-28 8:51 ` Sebastian Spaeth [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-01-21 9:59 [PATCH 0/3] Speedups and enhancements of notmuch new Michal Sojka
2011-01-21 9:59 ` [PATCH 1/3] new: Do not defer maildir flag synchronization during the first run Michal Sojka
2011-01-25 22:42 ` Austin Clements
2011-01-26 9:15 ` Carl Worth
2011-01-26 11:59 ` Carl Worth
2011-01-26 15:07 ` Austin Clements
2011-01-26 16:50 ` Michal Sojka
2011-01-27 5:04 ` Carl Worth
2011-01-27 5:43 ` Austin Clements
2011-01-30 0:21 ` Rob Browning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zkql76ni.fsf@SSpaeth.de \
--to=sebastian@sspaeth.de \
--cc=amdragon@mit.edu \
--cc=cworth@cworth.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).