From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 2853A431FB6 for ; Sat, 16 Apr 2011 06:07:09 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Qh7RsJfTzg3K for ; Sat, 16 Apr 2011 06:07:05 -0700 (PDT) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 17D28431FB5 for ; Sat, 16 Apr 2011 06:07:04 -0700 (PDT) Received: by wwi36 with SMTP id 36so3684076wwi.2 for ; Sat, 16 Apr 2011 06:07:04 -0700 (PDT) Received: by 10.227.59.134 with SMTP id l6mr3055901wbh.34.1302959223891; Sat, 16 Apr 2011 06:07:03 -0700 (PDT) Received: from localhost (99.28-240-81.adsl-dyn.isp.belgacom.be [81.240.28.99]) by mx.google.com with ESMTPS id l24sm2161812wbc.30.2011.04.16.06.07.01 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 16 Apr 2011 06:07:02 -0700 (PDT) From: Pieter Praet To: Kan-Ru Chen , notmuch@notmuchmail.org Subject: Re: [PATCH 1/2] emacs: notmuch-hello: Avoid going to end-of-line in search box In-Reply-To: <1280195325-9066-2-git-send-email-kanru@kanru.info> References: <1280195325-9066-1-git-send-email-kanru@kanru.info> <1280195325-9066-2-git-send-email-kanru@kanru.info> User-Agent: Notmuch/0.5-86-g4875299 (http://notmuchmail.org) Emacs/23.1.50.1 (x86_64-pc-linux-gnu) Date: Sat, 16 Apr 2011 15:07:00 +0200 Message-ID: <87zknquyyz.fsf@A7GMS.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Apr 2011 13:07:09 -0000 On Tue, 27 Jul 2010 09:48:44 +0800, Kan-Ru Chen wrote: > widget-end-of-line checks eolp to decide whether C-e in a fixed size > field should go to the end of the text in the field or the end of > the field itself. So put a trailing white space to pad the search > field. > > Previous behavior: > > Search: [text _] > > Now: > > Search: [text_ ] > --- > emacs/notmuch-hello.el | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el > index f8ae332..6ef03bb 100644 > --- a/emacs/notmuch-hello.el > +++ b/emacs/notmuch-hello.el > @@ -416,10 +416,10 @@ Complete list of currently available key bindings: > ;; Leave some space at the start and end of the > ;; search boxes. > :size (max 8 (- (window-width) notmuch-hello-indent > - (length "Search: "))) > + (length "Search: ") 1 )) > :action (lambda (widget &rest ignore) > (notmuch-hello-search (widget-value widget)))) > - (widget-insert "\n") > + (widget-insert " \n") > > (when notmuch-hello-recent-searches > (widget-insert "\nRecent searches: ") > -- > 1.7.1 > > +1 Can't imagine how this has been collecting dust for so long. Very useful, very concise, and still applies cleanly to HEAD. Peace -Pieter