From: Pieter Praet <pieter@praet.org>
To: Kan-Ru Chen <kanru@kanru.info>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] emacs: notmuch-hello: Avoid going to end-of-line in search box
Date: Sat, 16 Apr 2011 15:07:00 +0200 [thread overview]
Message-ID: <87zknquyyz.fsf@A7GMS.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <1280195325-9066-2-git-send-email-kanru@kanru.info>
On Tue, 27 Jul 2010 09:48:44 +0800, Kan-Ru Chen <kanru@kanru.info> wrote:
> widget-end-of-line checks eolp to decide whether C-e in a fixed size
> field should go to the end of the text in the field or the end of
> the field itself. So put a trailing white space to pad the search
> field.
>
> Previous behavior:
>
> Search: [text _]
>
> Now:
>
> Search: [text_ ]
> ---
> emacs/notmuch-hello.el | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
> index f8ae332..6ef03bb 100644
> --- a/emacs/notmuch-hello.el
> +++ b/emacs/notmuch-hello.el
> @@ -416,10 +416,10 @@ Complete list of currently available key bindings:
> ;; Leave some space at the start and end of the
> ;; search boxes.
> :size (max 8 (- (window-width) notmuch-hello-indent
> - (length "Search: ")))
> + (length "Search: ") 1 ))
> :action (lambda (widget &rest ignore)
> (notmuch-hello-search (widget-value widget))))
> - (widget-insert "\n")
> + (widget-insert " \n")
>
> (when notmuch-hello-recent-searches
> (widget-insert "\nRecent searches: ")
> --
> 1.7.1
>
>
+1
Can't imagine how this has been collecting dust for so long.
Very useful, very concise, and still applies cleanly to HEAD.
Peace
-Pieter
next prev parent reply other threads:[~2011-04-16 13:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 1:48 [PATCH 0/2] Usability improvements to notmuch-hello Kan-Ru Chen
2010-07-27 1:48 ` [PATCH 1/2] emacs: notmuch-hello: Avoid going to end-of-line in search box Kan-Ru Chen
2011-04-16 13:07 ` Pieter Praet [this message]
2010-07-27 1:48 ` [PATCH 2/2] emacs: notmuch-hello: Add "n" and "p" to mod map Kan-Ru Chen
2011-04-16 13:26 ` Pieter Praet
2011-04-18 7:36 ` Xavier Maillard
2011-04-18 9:55 ` Pieter Praet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zknquyyz.fsf@A7GMS.i-did-not-set--mail-host-address--so-tickle-me \
--to=pieter@praet.org \
--cc=kanru@kanru.info \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).