Re: debian: Override RPATH_LDFLAGS

Re: debian: Override RPATH_LDFLAGS

[Carl Worth]

[-- Attachment #1: Type: text/plain, Size: 1795 bytes --]

On Wed, 22 Jun 2011 18:48:34 -0700 (PDT), (David Bremner) wrote:
>     Probably there is a nicer way to do this; perhaps it should be a
>     configure option.
>     (cherry picked from commit 387dc520dd68cc805e390f3a1399f85b5d5bd83a)

This nicer way involved automatic detection of when rpath is
needed. That was the intent always, but it was broken for a while,
(leading to this patch I believe).

The automatic detection should actually be working now. See the commit
referenced below.

So, you'll want to test it, of course, but I think you can (and should)
drop this override of RPATH_LDFLAGS from the Debian packaging now.

-Carl

commit 574f408816e636f677b14384c18cc2e388991411
Author: Carl Worth <cworth@cworth.org>
Date:   Wed Jun 1 13:02:58 2011 -0700

    configure: Fix detection of libdir in ldconfig configuration
    
    Ever since commit b4b5e9ce4dac62111ec11da6d22b7e618056801f the
    detection of libdir in the ldconfig configuration has been broken,
    resulting in RPATH being set when not needed and not wanted.
    
    The cause was a change from an IFS setting of:
    
    	IFS="$(printf '\n\t')"
    
    to a new setting of:
    
    	IFS="$(printf '\n')"
    
    That looks desirable since we want to split the output of ldconfig
    based on newlines, (and not split on any filename that might have an
    embedded tab in it). The subtle bug in the above is that the shell
    trims any trailing newlines when performing command substitution so
    the final statement above was equivalent to:
    
    	IFS=''
    
    which prevented any splitting of the ldconfig output at all.
    
    Fix this by avoiding command substitution and just using a literal
    newline in the source file for setting this variable.

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: debian: Override RPATH_LDFLAGS

[David Bremner]

On Thu, 23 Jun 2011 14:38:42 -0700, Carl Worth <cworth@cworth.org> wrote:
> 
> So, you'll want to test it, of course, but I think you can (and should)
> drop this override of RPATH_LDFLAGS from the Debian packaging now.

As you say, it seems to work without this patch. Revert pushed to
master.

d