unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Sebastian Spaeth <Sebastian@SSpaeth.de>
To: Michael Hudson-Doyle <michael.hudson@canonical.com>,
	notmuch@notmuchmail.org, David Bremner <david@tethera.net>
Subject: Re: [PATCH] Do not import notmuch in setup.py (again).
Date: Wed, 24 Aug 2011 09:20:51 +0200	[thread overview]
Message-ID: <87zkizxoks.fsf@SSpaeth.de> (raw)
In-Reply-To: <87d3fvvdqp.fsf@canonical.com>

[-- Attachment #1: Type: text/plain, Size: 791 bytes --]

On Wed, 24 Aug 2011 12:45:34 +1200, Michael Hudson-Doyle <michael.hudson@canonical.com> wrote:
> Revert part of 8826f.  As explained in c39b492c, importing notmuch in setup.py breaks make -f debian/rules clean in an environment that does not have notmuch installed already.

Ahh, sorry, I must have missed that patch (or forgotten about it). I
solved this now by having the version number in version.py (which
contains nothing else, so David Bremner can easily overwrite it with
makefile magic :-)).

@David, feel free to automagically modify (or overwrite)
bindings/python/notmuch/version.py.

We read in version.py using execfile() and verify that getting the
version number actually worked.

Sorry, I did not apply your patch as I had fixed this before even seeing
your patch.

Sebastian

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2011-08-24  7:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-24  0:45 [PATCH] Do not import notmuch in setup.py (again) Michael Hudson-Doyle
2011-08-24  7:20 ` Sebastian Spaeth [this message]
2011-08-24 10:46   ` Michael Hudson-Doyle
2011-09-05 12:04     ` David Bremner
2011-09-06 15:04       ` Sebastian Spaeth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zkizxoks.fsf@SSpaeth.de \
    --to=sebastian@sspaeth.de \
    --cc=david@tethera.net \
    --cc=michael.hudson@canonical.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).