From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 44430431FD0 for ; Wed, 2 Nov 2011 10:22:16 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OPtr9tc5CLIA for ; Wed, 2 Nov 2011 10:22:14 -0700 (PDT) Received: from mail-ww0-f41.google.com (mail-ww0-f41.google.com [74.125.82.41]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 3EAD8431FB6 for ; Wed, 2 Nov 2011 10:22:14 -0700 (PDT) Received: by wwf27 with SMTP id 27so4075660wwf.2 for ; Wed, 02 Nov 2011 10:22:13 -0700 (PDT) Received: by 10.227.205.132 with SMTP id fq4mr6949939wbb.5.1320254532874; Wed, 02 Nov 2011 10:22:12 -0700 (PDT) Received: from localhost ([109.131.187.47]) by mx.google.com with ESMTPS id b5sm5328292wbh.4.2011.11.02.10.22.11 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 02 Nov 2011 10:22:12 -0700 (PDT) From: Pieter Praet To: Ali Polatel Subject: Re: set test prereqs (Emacs, GDB, GPG) v4 In-Reply-To: <20111101202025.GA8248@hayalet> References: <1320176954-4897-1-git-send-email-pieter@praet.org> <20111101202025.GA8248@hayalet> User-Agent: Notmuch/0.9+33~gadde72d (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) Date: Wed, 02 Nov 2011 18:21:34 +0100 Message-ID: <87zkgemodd.fsf@praet.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Nov 2011 17:22:16 -0000 On Tue, 1 Nov 2011 22:20:25 +0200, Ali Polatel wrote: > On Tue, Nov 01, 2011 at 08:49:10PM +0100, Pieter Praet wrote: > >Rebased to current master. > > > >Previous version: > > id:"1307016220-17509-1-git-send-email-pieter@praet.org" > > > >Discussion: > > id:"1317660447-27520-1-git-send-email-schnouki@schnouki.net" > > > > Thanks for the nice work! > I want to share one thing which came up to my mind during reading > through them. Since we require bash for tests, we might go for using > bash's builtin 'type -P foo' instead of 'which foo'. Not that it's > important, just wondered "why not?" > > -alip Good suggestion! In fact, we might as well immediately go for full POSIX compliance. How do you feel about using `hash' ? Besides being available in POSIX sh, it has the added benefit of making subsequent lookups faster [*]. Peace -- Pieter [*] This statement only applies to the shell built-in. Other types of hash may distort your perception of time, which is likely to result in significantly slower lookups.