From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id AFA42429E27 for ; Sat, 12 Nov 2011 23:07:00 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cOYru4-pYrbX for ; Sat, 12 Nov 2011 23:07:00 -0800 (PST) Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id E60E9431FB6 for ; Sat, 12 Nov 2011 23:06:59 -0800 (PST) Received: by bkaq10 with SMTP id q10so5704373bka.26 for ; Sat, 12 Nov 2011 23:06:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; bh=PwJvv8ktTRcikpmk3aZtJ7UIF6us/3ab+STIotPKSRY=; b=h1AkeVcZrR9WgcYU/7Ufaoqqsorcu9V2tihuRMj/O3dvDEe3gXa9pT7Jnvlo/hZKo7 IYlvDt4RuJ4l+BHZjtrSdkudmu6KQa6E+dwC644SOHf7QUmAG9KDbcBwAXKzq8om/yo7 IKud2pMJDr058tgoT4ecEssAtvR3/jXmYVhYw= Received: by 10.204.14.208 with SMTP id h16mr14499689bka.2.1321168018501; Sat, 12 Nov 2011 23:06:58 -0800 (PST) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id z7sm23260385bka.1.2011.11.12.23.06.56 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 12 Nov 2011 23:06:56 -0800 (PST) From: Dmitry Kurochkin To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH] test: do not hide test_emacs errors In-Reply-To: <87mxc1mlqm.fsf@rocinante.cs.unb.ca> References: <1309487028-18786-1-git-send-email-dmitry.kurochkin@gmail.com> <87mxc1mlqm.fsf@rocinante.cs.unb.ca> User-Agent: Notmuch/0.9+55~g81c615b (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sun, 13 Nov 2011 11:06:43 +0400 Message-ID: <87zkg01oxo.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Nov 2011 07:07:00 -0000 On Sat, 12 Nov 2011 09:57:53 -0500, David Bremner wrote: > On Fri, 1 Jul 2011 06:23:48 +0400, Dmitry Kurochkin wrote: > > Do not redirect test_emacs stderr to /dev/null. Test_emacs uses > > emacsclient(1) now and it does not print unwanted messages (like > > those from `message') to stderr. But it does print useful > > errors, e.g. when emacs server connection fails, given expression > > is not valid or undefined function is called. > > Is this patch still relevant now that we use dtach to run the tests? > It is still relevant. If test_emacs prints any errors, we should see them. If it does not, we should remove the redirection. But we need to check for other similar cases. New test cases may have been added with test_emacs stderr redirect. > I didn't notice any difference, but maybe I was not supposed to. > I think that is expected. Regards, Dmitry > d