[PATCH] emacs: Use notmuch-command variable in process-lines.

[PATCH] emacs: Use notmuch-command variable in process-lines.

[Chris Gray]

The process-lines function calls the notmuch binary.  The location of
the binary may have been customized by the user, so it is better to
use the customized location rather than allowing the process-lines
function to search the user's PATH for the binary.
---
 emacs/notmuch.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index f15a75b..8936149 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -885,7 +885,7 @@ PROMPT is the string to prompt with."
 		      "subject:" "attachment:")
 		(mapcar (lambda (tag)
 			  (concat "tag:" tag))
-			(process-lines "notmuch" "search" "--output=tags" "*")))))
+			(process-lines notmuch-command "search" "--output=tags" "*")))))
     (let ((keymap (copy-keymap minibuffer-local-map))
 	  (minibuffer-completion-table
 	   (completion-table-dynamic
-- 
1.7.7.3

Re: [PATCH] emacs: Use notmuch-command variable in process-lines.

[Jani Nikula]

Good catch, looks good to me.

BR,
Jani.

On Tue, 29 Nov 2011 10:58:31 -0700, Chris Gray <chrismgray@gmail.com> wrote:
> The process-lines function calls the notmuch binary.  The location of
> the binary may have been customized by the user, so it is better to
> use the customized location rather than allowing the process-lines
> function to search the user's PATH for the binary.
> ---
>  emacs/notmuch.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index f15a75b..8936149 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -885,7 +885,7 @@ PROMPT is the string to prompt with."
>  		      "subject:" "attachment:")
>  		(mapcar (lambda (tag)
>  			  (concat "tag:" tag))
> -			(process-lines "notmuch" "search" "--output=tags" "*")))))
> +			(process-lines notmuch-command "search" "--output=tags" "*")))))
>      (let ((keymap (copy-keymap minibuffer-local-map))
>  	  (minibuffer-completion-table
>  	   (completion-table-dynamic
> -- 
> 1.7.7.3
> 
> 
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: Use notmuch-command variable in process-lines.

[Dmitry Kurochkin]

+1

Regards,
  Dmitry

Re: [PATCH] emacs: Use notmuch-command variable in process-lines.

[Tomi Ollila]

On Tue, 29 Nov 2011 10:58:31 -0700, Chris Gray <chrismgray@gmail.com> wrote:
> The process-lines function calls the notmuch binary.  The location of
> the binary may have been customized by the user, so it is better to
> use the customized location rather than allowing the process-lines
> function to search the user's PATH for the binary.

anyone who modifies notmuch-command variable may get affected by this
bug so I vote for quick inclusion.

Tomi

Re: [PATCH] emacs: Use notmuch-command variable in process-lines.

[David Bremner]

On Tue, 29 Nov 2011 10:58:31 -0700, Chris Gray <chrismgray@gmail.com> wrote:
> The process-lines function calls the notmuch binary.  The location of
> the binary may have been customized by the user, so it is better to
> use the customized location rather than allowing the process-lines
> function to search the user's PATH for the binary.

Pushed, thanks.

d