From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 30A5A429E25 for ; Thu, 15 Dec 2011 17:00:03 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S-Kn-L5+kE+n for ; Thu, 15 Dec 2011 17:00:02 -0800 (PST) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 880F4431FD0 for ; Thu, 15 Dec 2011 17:00:02 -0800 (PST) Received: by wgbds13 with SMTP id ds13so4059669wgb.2 for ; Thu, 15 Dec 2011 17:00:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; bh=MVeHtDHhlBMsqtS3CuXKSdZ2eHy6b4MTbwGtnEa+/r0=; b=Pf6jwu05kxWQLTH0Ahrvt8jTWcQ4H8d9Fc0KXSrjywHM2Ndw4Fi3LhuR7m3i3TPiVw 11tpRyxreux6FXu//HhA/NDbQlbQI+y33Rb0zjFtNrKB/NGWaEcrTy4hcEM7a2bXQ2JF /fvA6h0r+BOJm0O2FL3/2/QUukSyO8h3rZYiM= Received: by 10.180.91.137 with SMTP id ce9mr9727624wib.5.1323997201349; Thu, 15 Dec 2011 17:00:01 -0800 (PST) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id ff1sm12114883wbb.5.2011.12.15.17.00.00 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 15 Dec 2011 17:00:00 -0800 (PST) From: Dmitry Kurochkin To: Thomas Jost , notmuch@notmuchmail.org Subject: Re: [PATCH v3 3/4] emacs: rename notmuch-decimal-separator to notmuch-thousands-separator In-Reply-To: <1323797532-597-4-git-send-email-schnouki@schnouki.net> References: <87d3cx2t38.fsf@rocinante.cs.unb.ca> <1323797532-597-1-git-send-email-schnouki@schnouki.net> <1323797532-597-4-git-send-email-schnouki@schnouki.net> User-Agent: Notmuch/0.10.2+96~g74e5ae5 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Fri, 16 Dec 2011 04:59:22 +0400 Message-ID: <87zkets55h.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Dec 2011 01:00:03 -0000 On Tue, 13 Dec 2011 18:32:11 +0100, Thomas Jost wrote: > In 123,456.78, "." is the decimal separator, but "," is the thousands separator. > > This commit also mentions the space being used as thousands separator in several > European countries. > --- What do perople think about making the thousands separator a space by default? > emacs/notmuch-hello.el | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el > index 0582cae..0fe9c1d 100644 > --- a/emacs/notmuch-hello.el > +++ b/emacs/notmuch-hello.el > @@ -131,10 +131,10 @@ So: > (integer :tag "Number of characters") > (float :tag "Fraction of window"))) > > -(defcustom notmuch-decimal-separator "," > - "The string used as a decimal separator. > +(defcustom notmuch-thousands-separator "," > + "The string used as a thousands separator. I suggest renaming this to notmuch-hello-thousands-separator. Looks good otherwise. Regards, Dmitry > > -Typically \",\" in the US and UK and \".\" in Europe." > +Typically \",\" in the US and UK and \".\" or \" \" in Europe." > :group 'notmuch > :type 'string) > > @@ -159,7 +159,7 @@ Typically \",\" in the US and UK and \".\" in Europe." > (apply #'concat > (number-to-string (car result)) > (mapcar (lambda (elem) > - (format "%s%03d" notmuch-decimal-separator elem)) > + (format "%s%03d" notmuch-thousands-separator elem)) > (cdr result))))) > > (defun notmuch-hello-trim (search) > -- > 1.7.8 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch