From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH v4 0/4] First step of 'show' rewrite
Date: Fri, 23 Dec 2011 23:55:28 -0800 [thread overview]
Message-ID: <87zkeijte7.fsf@servo.finestructure.net> (raw)
In-Reply-To: <1324698348-27620-1-git-send-email-amdragon@mit.edu>
[-- Attachment #1: Type: text/plain, Size: 718 bytes --]
On Fri, 23 Dec 2011 22:45:44 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> This addresses Dmitry's and Jameson's review comments from
> id:"87k46572f7.fsf@gmail.com"
> id:"87liqk5dly.fsf@servo.finestructure.net"
> id:"87hb187iu6.fsf@gmail.com"
> and rebases to current master.
>
> I'd like a quick eye over this to make sure I didn't screw anything up
> in the latest version, but otherwise I think it's ready to go in.
Hey, Austin. Thanks so much for the rework. I have one very minor
comment, but other than that it all looks really good to me (as usual).
All tests pass as expected when applied to master. I'm looking forward
to what else you've got in store on top of this!
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2011-12-24 7:55 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 2:21 [PATCH 0/4] First step of 'show' rewrite Austin Clements
2011-11-28 2:21 ` [PATCH 1/4] show: Pass notmuch_message_t instead of path to show_message_body Austin Clements
2011-11-28 2:21 ` [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal Austin Clements
2011-11-29 19:11 ` Jani Nikula
2011-12-04 19:26 ` Austin Clements
2011-11-28 2:21 ` [PATCH 3/4] Utility function to seek in MIME trees in depth-first order Austin Clements
2011-11-28 2:21 ` [PATCH 4/4] show: Rewrite show_message_body to use the MIME tree interface Austin Clements
2011-11-28 19:44 ` Jani Nikula
2011-11-29 14:37 ` [PATCH 0/4] First step of 'show' rewrite Jameson Graef Rollins
2011-12-04 19:31 ` [PATCH v2 " Austin Clements
2011-12-04 19:31 ` [PATCH 1/4] show: Pass notmuch_message_t instead of path to show_message_body Austin Clements
2011-12-09 19:05 ` Dmitry Kurochkin
2011-12-09 19:54 ` Austin Clements
2011-12-09 19:59 ` Dmitry Kurochkin
2011-12-04 19:31 ` [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal Austin Clements
2011-12-04 19:31 ` [PATCH 3/4] Utility function to seek in MIME trees in depth-first order Austin Clements
2011-12-04 19:31 ` [PATCH 4/4] show: Rewrite show_message_body to use the MIME tree interface Austin Clements
2011-12-09 17:39 ` [PATCH v2 0/4] First step of 'show' rewrite Austin Clements
2011-12-09 17:40 ` Dmitry Kurochkin
2011-12-09 17:51 ` Jameson Graef Rollins
2011-12-09 19:54 ` [PATCH v3 " Austin Clements
2011-12-09 19:54 ` [PATCH 1/4] show: Pass notmuch_message_t instead of path to show_message_body Austin Clements
2011-12-09 19:54 ` [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal Austin Clements
2011-12-09 23:25 ` Dmitry Kurochkin
2011-12-10 21:17 ` Jameson Graef Rollins
2011-12-24 3:45 ` Austin Clements
2011-12-24 3:45 ` Austin Clements
2011-12-27 14:27 ` Daniel Kahn Gillmor
2011-12-28 3:23 ` Austin Clements
2011-12-10 21:19 ` Jameson Graef Rollins
2011-12-09 19:54 ` [PATCH 3/4] Utility function to seek in MIME trees in depth-first order Austin Clements
2011-12-10 11:43 ` Dmitry Kurochkin
2011-12-24 3:46 ` Austin Clements
2011-12-25 23:39 ` Dmitry Kurochkin
2011-12-09 19:54 ` [PATCH 4/4] show: Rewrite show_message_body to use the MIME tree interface Austin Clements
2011-12-11 10:34 ` Dmitry Kurochkin
2011-12-24 3:46 ` Austin Clements
2011-12-10 21:16 ` [PATCH v3 0/4] First step of 'show' rewrite Jameson Graef Rollins
2011-12-11 10:41 ` Dmitry Kurochkin
2011-12-15 11:03 ` David Bremner
2011-12-24 3:45 ` [PATCH v4 " Austin Clements
2011-12-24 3:45 ` [PATCH v4 1/4] show: Pass notmuch_message_t instead of path to show_message_body Austin Clements
2011-12-24 3:45 ` [PATCH v4 2/4] Introduce a generic tree-like abstraction for MIME traversal Austin Clements
2011-12-24 7:55 ` Jameson Graef Rollins
2011-12-24 8:05 ` Dmitry Kurochkin
2011-12-24 19:03 ` Austin Clements
2011-12-24 3:45 ` [PATCH v4 3/4] Utility function to seek in MIME trees in depth-first order Austin Clements
2011-12-24 3:45 ` [PATCH v4 4/4] show: Rewrite show_message_body to use the MIME tree interface Austin Clements
2011-12-24 3:58 ` [PATCH v4 0/4] First step of 'show' rewrite Dmitry Kurochkin
2011-12-24 7:55 ` Jameson Graef Rollins [this message]
2011-12-24 18:52 ` [PATCH v5 " Austin Clements
2011-12-24 18:52 ` [PATCH v5 1/4] show: Pass notmuch_message_t instead of path to show_message_body Austin Clements
2011-12-24 18:52 ` [PATCH v5 2/4] Introduce a generic tree-like abstraction for MIME traversal Austin Clements
2011-12-24 18:52 ` [PATCH v5 3/4] Utility function to seek in MIME trees in depth-first order Austin Clements
2011-12-24 18:52 ` [PATCH v5 4/4] show: Rewrite show_message_body to use the MIME tree interface Austin Clements
2011-12-25 23:35 ` [PATCH v5 0/4] First step of 'show' rewrite Dmitry Kurochkin
2011-12-26 2:42 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zkeijte7.fsf@servo.finestructure.net \
--to=jrollins@finestructure.net \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).