unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Mark Walters <markwalters1009@gmail.com>
To: Jani Nikula <jani@nikula.org>,
	notmuch@notmuchmail.org, david@tethera.net
Subject: Re: [PATCH 0/4] notmuch reply bugfix & reply to sender only
Date: Fri, 06 Jan 2012 14:20:27 +0000	[thread overview]
Message-ID: <87zke0diac.fsf@qmul.ac.uk> (raw)
In-Reply-To: <87fwft80wg.fsf@nikula.org>


Hello

I have now compared the two patch sets. They seem very similar but I
think yours is a little bit nicer in all respects except I prefer my
use of "g_mime_message_get_all_recipients (reply) == NULL".

However, one case that is slightly less clear with my approach is
what to do about reply-to-thread (or indeed any reply to more than one
message). I did not add a reply-to-thread not_all option as I wasn't
sure what it should do. Perhaps we could even make reply-to-one return
an error if the search gives more than one message? 

Best wishes

Mark

  parent reply	other threads:[~2012-01-06 14:20 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-05 20:25 [PATCH 0/4] notmuch reply bugfix & reply to sender only Jani Nikula
2012-01-05 20:25 ` [PATCH 1/4] cli: fix use of uninitialized variable in "notmuch reply" Jani Nikula
2012-01-06  3:22   ` David Bremner
2012-01-06  8:11     ` Jani Nikula
2012-01-06 11:57       ` David Bremner
2012-01-07  3:52   ` David Bremner
2012-01-07  7:31     ` Jani Nikula
2012-01-07 11:57       ` Mark Walters
2012-01-07 12:14       ` David Bremner
2012-01-05 20:25 ` [PATCH 2/4] cli: convert "notmuch reply" to use the new argument parser Jani Nikula
2012-01-05 20:25 ` [PATCH 3/4] cli: add support for replying just to the sender in "notmuch reply" Jani Nikula
2012-01-05 20:25 ` [PATCH 4/4] emacs: add support for replying just to the sender of messages and threads Jani Nikula
2012-01-05 20:33 ` [PATCH 0/4] notmuch reply bugfix & reply to sender only Jameson Graef Rollins
2012-01-07 19:25   ` Mueen Nawaz
2012-01-05 22:01 ` Mark Walters
2012-01-06 12:34   ` Jani Nikula
2012-01-06 13:32     ` Mark Walters
2012-01-06 13:34       ` [PATCH 1/4] Add the option "--reply-to" to notmuch reply Mark Walters
2012-01-08 12:47         ` Jani Nikula
2012-01-08 15:08           ` Mark Walters
2012-01-08 16:11             ` Jani Nikula
2012-01-06 13:34       ` [PATCH 2/4] Update the man page for notmuch-reply to give the syntax for the --reply-to option Mark Walters
2012-01-06 13:34       ` [PATCH 3/4] Emacs changes for reply-to-sender Mark Walters
2012-01-06 13:34       ` [PATCH 4/4] add tests " Mark Walters
2012-01-06 14:20     ` Mark Walters [this message]
2012-01-06  0:01 ` [PATCH 0/4] notmuch reply bugfix & reply to sender only Adam Wolfe Gordon
2012-01-06 22:11   ` Tomi Ollila
2012-01-06  8:54 ` David Edmondson
2012-01-08 21:48 ` [PATCH v2 0/6] reply to sender Jani Nikula
2012-01-09  8:22   ` David Edmondson
2012-01-09 18:55   ` Dmitry Kurochkin
2012-01-08 21:48 ` [PATCH v2 1/6] cli: fix use of uninitialized variable in "notmuch reply" Jani Nikula
2012-01-08 21:48 ` [PATCH v2 2/6] cli: convert "notmuch reply" to use the new argument parser Jani Nikula
2012-01-08 21:48 ` [PATCH v2 3/6] cli: add support for replying just to the sender in "notmuch reply" Jani Nikula
2012-01-08 23:23   ` Mark Walters
2012-01-09  9:41     ` Jani Nikula
2012-01-09 11:13       ` Mark Walters
2012-01-08 21:48 ` [PATCH v2 4/6] emacs: add support for replying just to the sender Jani Nikula
2012-01-08 21:48 ` [PATCH v2 5/6] emacs: bind 'r' to reply-to-sender and 'R' to reply-to-all Jani Nikula
2012-01-08 22:01   ` Jeremy Nickurak
2012-01-08 23:32     ` Jameson Graef Rollins
2012-01-08 23:56       ` Jeremy Nickurak
2012-01-09 14:10     ` is there a default reply function? (was: Re: [PATCH v2 5/6] emacs: bind 'r' to reply-to-sender and 'R' to reply-to-all) Gregor Zattler
2012-01-08 21:48 ` [PATCH v2 6/6] test: add tests for "notmuch reply" --reply-to=sender Jani Nikula
2012-01-10 19:54 ` [PATCH v3 0/4] reply to sender Jani Nikula
2012-01-10 19:54 ` [PATCH v3 1/4] cli: add support for replying just to the sender in "notmuch reply" Jani Nikula
2012-01-12  3:31   ` Austin Clements
2012-01-10 19:54 ` [PATCH v3 2/4] emacs: add support for replying just to the sender Jani Nikula
2012-01-11  8:20   ` David Edmondson
2012-01-11  8:45     ` Jani Nikula
2012-01-11  9:08       ` David Edmondson
2012-01-11 21:15     ` Aaron Ecay
2012-01-11 22:08       ` Jani Nikula
2012-01-10 19:54 ` [PATCH v3 3/4] emacs: bind 'r' to reply-to-sender and 'R' to reply-to-all Jani Nikula
2012-01-11  8:21   ` David Edmondson
2012-01-10 19:54 ` [PATCH v3 4/4] test: add tests for "notmuch reply" --reply-to=sender Jani Nikula
2012-01-12  3:50   ` Austin Clements
2012-01-12 12:59     ` Tomi Ollila
2012-01-12 21:40 ` [PATCH v4 0/5] reply to sender Jani Nikula
2012-01-12 21:40 ` [PATCH v4 1/5] cli: slightly refactor "notmuch reply" address scanning functions Jani Nikula
2012-01-12 21:59   ` Austin Clements
2012-01-14 14:22     ` Jani Nikula
2012-01-12 23:28   ` Mark Walters
2012-01-12 21:40 ` [PATCH v4 2/5] cli: add support for replying just to the sender in "notmuch reply" Jani Nikula
2012-01-12 22:02   ` Austin Clements
2012-01-12 23:46   ` Mark Walters
2012-01-12 21:40 ` [PATCH v4 3/5] emacs: add support for replying just to the sender Jani Nikula
2012-01-12 21:40 ` [PATCH v4 4/5] emacs: bind 'r' to reply-to-sender and 'R' to reply-to-all Jani Nikula
2012-01-12 21:40 ` [PATCH v4 5/5] test: add tests for "notmuch reply" --reply-to=sender Jani Nikula
2012-01-14 14:46 ` [PATCH v5 0/5] reply to sender Jani Nikula
2012-01-14 14:46 ` [PATCH v5 1/5] cli: slightly refactor "notmuch reply" address scanning functions Jani Nikula
2012-01-14 15:31   ` David Bremner
2012-01-14 16:48     ` Jani Nikula
2012-01-16 18:06     ` Dmitry Kurochkin
2012-01-16 18:40       ` David Edmondson
2012-01-16 19:26       ` David Bremner
2012-01-16 19:32       ` Jameson Graef Rollins
2012-01-14 14:46 ` [PATCH v5 2/5] cli: add support for replying just to the sender in "notmuch reply" Jani Nikula
2012-01-14 14:46 ` [PATCH v5 3/5] emacs: add support for replying just to the sender Jani Nikula
2012-01-14 14:46 ` [PATCH v5 4/5] emacs: bind 'r' to reply-to-sender and 'R' to reply-to-all Jani Nikula
2012-01-14 14:46 ` [PATCH v5 5/5] test: add tests for "notmuch reply" --reply-to=sender Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zke0diac.fsf@qmul.ac.uk \
    --to=markwalters1009@gmail.com \
    --cc=david@tethera.net \
    --cc=jani@nikula.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).