From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Austin Clements <amdragon@MIT.EDU>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH v2] emacs: Make the part content available to the mm-inline* checks.
Date: Wed, 18 Jan 2012 23:59:03 +0400 [thread overview]
Message-ID: <87zkdk7pfc.fsf@gmail.com> (raw)
In-Reply-To: <20120118193501.GG16740@mit.edu>
On Wed, 18 Jan 2012 14:35:01 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> Quoth Dmitry Kurochkin on Jan 18 at 11:00 pm:
> > On Wed, 18 Jan 2012 18:30:36 +0000, David Edmondson <dme@dme.org> wrote:
> > > On Wed, 18 Jan 2012 22:04:36 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > > > On Wed, 18 Jan 2012 17:39:31 +0000, David Edmondson <dme@dme.org> wrote:
> > > > > The `mm-inlinable-p' and `mm-inlined-p' functions work better if they
> > > > > have access to the data of the relevant part, so load that content
> > > > > before calling either function.
> > > > >
> > > > > This fixes the display of attached image/jpeg parts, for example.
> > > >
> > > > Not so long ago I made an opposite change to avoid fetching useless
> > > > parts (e.g. audio files). Looks like we need a better check here. Can
> > > > we know from Content-Type if fetching a part body would be useful?
> > >
> > > What if `notmuch-show-insert-part-*/*' consulted a list of content-type
> > > regexps to attempt to inline?
> > >
> > > That would allow a sane default (("image/*" "text/*") perhaps), but also
> > > allow more to be added to that list (or some to be removed), either by
> > > code that detected the (in)ability to render it or the user.
> >
> > Perhaps there is such a list in mm already?
>
> Shouldn't we only be doing this for parts with inline (or not
> attachment) content-disposition? That's cheap to check. Or do we
> actually want things like image attachments to get inlined, despite
> their disposition?
It may be good to have this behavior configurable. I would like Emacs
to display all part types that it can, independent from
content-disposition.
Anyway, this is a separate issue. In any case we want to fetch part
body only if it is useful.
Regards,
Dmitry
next prev parent reply other threads:[~2012-01-18 20:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 17:33 [PATCH] emacs: Make the part content available to the mm-inline* checks David Edmondson
2012-01-18 17:35 ` David Edmondson
2012-01-18 17:39 ` [PATCH v2] " David Edmondson
2012-01-18 18:04 ` Dmitry Kurochkin
2012-01-18 18:30 ` David Edmondson
2012-01-18 19:00 ` Dmitry Kurochkin
2012-01-18 19:35 ` Austin Clements
2012-01-18 19:59 ` Dmitry Kurochkin [this message]
2012-01-20 20:13 ` Jameson Graef Rollins
2012-01-23 8:00 ` David Edmondson
2012-01-19 7:39 ` David Edmondson
2012-01-19 9:23 ` Dmitry Kurochkin
2012-01-19 9:34 ` [PATCH] emacs: Make the part content available to `mm-inlinable-p' David Edmondson
2012-01-19 9:37 ` Dmitry Kurochkin
2012-01-19 17:31 ` Aaron Ecay
2012-01-20 14:18 ` Tomi Ollila
2012-01-20 20:04 ` Jameson Graef Rollins
2012-01-23 8:02 ` David Edmondson
2012-01-26 12:28 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zkdk7pfc.fsf@gmail.com \
--to=dmitry.kurochkin@gmail.com \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).