From: Jameson Graef Rollins <jrollins@finestructure.net>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.
Date: Fri, 20 Jan 2012 12:20:20 -0800 [thread overview]
Message-ID: <87zkdiktx7.fsf@servo.finestructure.net> (raw)
In-Reply-To: <1327052612-1040-2-git-send-email-dme@dme.org>
[-- Attachment #1: Type: text/plain, Size: 832 bytes --]
On Fri, 20 Jan 2012 09:43:31 +0000, David Edmondson <dme@dme.org> wrote:
> The buttons inserted for encrypted parts are slightly different now -
> previously the logic was that if a part was encrypted it would have
> the signature status inserted only if the encryption status was
> specified. Now the signature status will be inserted even without
> encryption status. My reading of the documentation says that this is
> correct, but I'm no expert. Comments?
I need some more time to review this patch, but I don't think this is
correct. The signature status of encrypted messages (or even if the
message was signed at all) comes from the decryption process. They're
not independent. If the decryption fails it's unknown if there was a
signature or not.
I need to look closer at this, though. Hopefully this weekend.
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2012-01-20 20:20 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 9:43 [PATCH 1/3] emacs: Tidy `notmuch-show-insert-part-header' David Edmondson
2012-01-20 9:43 ` [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header' David Edmondson
2012-01-20 20:20 ` Jameson Graef Rollins [this message]
2012-01-22 21:38 ` Jameson Graef Rollins
2012-01-23 8:16 ` David Edmondson
2012-01-23 8:52 ` Jameson Graef Rollins
2012-01-23 9:12 ` David Edmondson
2012-01-23 10:33 ` [PATCH 1/3 v2] " David Edmondson
2012-01-23 10:33 ` [PATCH 2/3 v2] emacs: Optionally hide some part headers David Edmondson
2012-01-23 10:33 ` [PATCH 3/3 v2] emacs: Don't insert a part header if it's the first part and text/* David Edmondson
2012-01-23 11:32 ` [PATCH 1/3 v2] emacs: Don't return the button from `notmuch-show-insert-part-header' David Edmondson
2012-01-20 9:43 ` [PATCH 3/3] emacs: Optionally hide some part headers David Edmondson
2012-01-24 12:53 ` optional hiding of some part headers v3 David Edmondson
2012-01-24 12:53 ` [PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header' David Edmondson
2012-01-24 18:46 ` Jameson Graef Rollins
2012-01-24 19:25 ` David Edmondson
2012-01-24 19:52 ` Jameson Graef Rollins
2012-01-25 6:15 ` David Edmondson
2012-01-24 19:33 ` Tomi Ollila
2012-01-24 12:53 ` [PATCH 2/3] emacs: Optionally hide some part headers David Edmondson
2012-01-24 19:34 ` Tomi Ollila
2012-01-24 12:53 ` [PATCH 3/3] emacs: Don't insert a part header if it's the first part and text/* David Edmondson
2012-01-24 19:46 ` Tomi Ollila
2012-02-06 15:39 ` [PATCH v3 0/3] part header code tidying and options David Edmondson
2012-02-06 15:39 ` [PATCH v2] emacs: Add more processing of displayed headers David Edmondson
2012-02-14 12:30 ` David Bremner
2012-02-14 13:28 ` David Edmondson
2012-10-12 19:11 ` Ethan Glasser-Camp
2012-02-06 15:39 ` [PATCH v3 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header' David Edmondson
2012-02-06 15:39 ` [PATCH v3 2/3] emacs: Optionally hide some part headers David Edmondson
2012-02-12 9:21 ` Mark Walters
2012-02-06 15:39 ` [PATCH v3 3/3] emacs: Don't insert a part header if it's the first part and text/* David Edmondson
2012-02-12 9:24 ` Mark Walters
2012-02-12 9:39 ` Mark Walters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zkdiktx7.fsf@servo.finestructure.net \
--to=jrollins@finestructure.net \
--cc=dme@dme.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).