unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: Re: [PATCH v2 0/3] Allow emacs to toggle display of all parts including multipart
Date: Mon, 03 Dec 2012 22:45:22 +0000	[thread overview]
Message-ID: <87zk1uvjp9.fsf@qmul.ac.uk> (raw)
In-Reply-To: <1354496317-24564-1-git-send-email-markwalters1009@gmail.com>


Hi

I now have a version which does this `right': using invisibility as with
citations and signatures etc. It is working but I need to look through
more carefully before posting.

Best wishes

Mark

On Mon, 03 Dec 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> This is rather more polished version of
> id:1351152563-27277-1-git-send-email-markwalters1009@gmail.com.
>
> The first patch modifies the behaviour of show refresh buffer to keep
> state more accurately where possible. It can never be perfect but it
> makes a reasonable attempt. This is independent of patches 2 and 3.
>
> The second patch allows the user to toggle the visibility of any part
> with 't' on the part button. It does this by storing a list of all
> parts that the user has over-ruled.
>
> The final patch binds the toggle to the default action in cases where
> the part has no filename. Is this a reasonable heuristic? And should
> it be customisable? In all cases the defined actions (save, view,
> other, and toggle) always do their action (ie they do not apply any
> heuristics)
>
> Overall I am pleased with the way it works. The one caveat is that it
> does redisplay the whole buffer when toggling the parts: it might be
> nice to use invisibility but that is beyond my lisp. Moreover it could
> be added at a later stage without changing the user experience.
>
>
> Best wishes
>
> Mark
>
>
> Mark Walters (3):
>   emacs: show: make refresh fix point(ish)
>   emacs: allow the user to toggle the visibility of
>     multipart/alternative parts
>   emacs: show make default part button toggle view when sensible
>
>  emacs/notmuch-show.el |   80 ++++++++++++++++++++++++++++++++++++++----------
>  1 files changed, 63 insertions(+), 17 deletions(-)
>
> -- 
> 1.7.9.1

      parent reply	other threads:[~2012-12-03 22:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-03  0:58 [PATCH v2 0/3] Allow emacs to toggle display of all parts including multipart Mark Walters
2012-12-03  0:58 ` [PATCH v2 1/3] emacs: show: make refresh fix point(ish) Mark Walters
2012-12-03  0:58 ` [PATCH v2 2/3] emacs: allow the user to toggle the visibility of multipart/alternative parts Mark Walters
2012-12-03  0:58 ` [PATCH v2 3/3] emacs: show make default part button toggle view when sensible Mark Walters
2012-12-03 22:45 ` Mark Walters [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zk1uvjp9.fsf@qmul.ac.uk \
    --to=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).