From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2] completion: complete bash completion rewrite
Date: Fri, 29 Mar 2013 09:28:00 -0400 [thread overview]
Message-ID: <87zjxmwd27.fsf@maritornes.cs.unb.ca> (raw)
In-Reply-To: <1362344368-27623-1-git-send-email-jani@nikula.org>
Jani Nikula <jani@nikula.org> writes:
> Rewrite the bash completion script to actually do something
> useful. Supported completions:
>
> * All the notmuch commands, command line arguments, and values for
> keyword arguments.
It seems to do what it says on the box. The bash code look OK, although
I'm probably not as fussy or expert as some.
> ---
>
> CAVEATS:
>
> There may be dependencies on the version of the bash-completion
> package. I do not know, and I don't have a huge interest in finding
> out. That way lay dragons.
I pushed this.
Maybe we should just document what versions of bash-completion it is
tested with. I tested it with bash-completion 2.0.
Could you make a followup patch with
something for completion/README and a line or so for NEWS?
prev parent reply other threads:[~2013-03-29 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-02 13:59 [PATCH] completion: complete bash completion rewrite Jani Nikula
2013-03-03 20:59 ` [PATCH v2] " Jani Nikula
2013-03-29 13:28 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zjxmwd27.fsf@maritornes.cs.unb.ca \
--to=david@tethera.net \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).