From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 5B352431FBC for ; Sun, 12 May 2013 04:20:18 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id doscuBKhrnIG for ; Sun, 12 May 2013 04:20:12 -0700 (PDT) Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 585E9431FAF for ; Sun, 12 May 2013 04:20:12 -0700 (PDT) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r4CBKASw029597; Sun, 12 May 2013 08:20:10 -0300 Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.82.78] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1UbUK2-00035X-DN; Sun, 12 May 2013 08:20:10 -0300 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1UbUJw-0002Me-P3; Sun, 12 May 2013 08:20:04 -0300 From: David Bremner To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH v2 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t In-Reply-To: <1368301809-12532-8-git-send-email-markwalters1009@gmail.com> References: <1368301809-12532-1-git-send-email-markwalters1009@gmail.com> <1368301809-12532-8-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.15.2+84~g12d5e4e (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Sun, 12 May 2013 08:20:04 -0300 Message-ID: <87zjw0la1n.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-Spam_bar: - X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 May 2013 11:20:18 -0000 Mark Walters writes: > - notmuch_query_set_omit_excluded (query, NOTMUCH_EXCLUDE_FALSE); > + notmuch_query_set_omit_excluded (query, NOTMUCH_EXCLUDE_FLAG); Shouldn't the documentation be updated to cover NOTMUCH_EXCLUDE_FLAG? I realize it is not _wrong_ as written, but it is a bit confusing not to cover all possible values of the enum. Other than that, the series LGTM. d