From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 2BDB2431FAF for ; Thu, 10 Oct 2013 03:41:17 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wF7Vnke8THeW for ; Thu, 10 Oct 2013 03:41:12 -0700 (PDT) Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 773FE431FAE for ; Thu, 10 Oct 2013 03:41:12 -0700 (PDT) Received: from remotemail by yantan.tethera.net with local (Exim 4.80) (envelope-from ) id 1VUDg7-0001XC-Kr; Thu, 10 Oct 2013 07:41:11 -0300 Received: (nullmailer pid 8065 invoked by uid 1000); Thu, 10 Oct 2013 10:41:08 -0000 From: David Bremner To: Peter Wang , Mark Walters Subject: Re: [PATCH 1/3] cli: add insert --must-index option In-Reply-To: <20130912001349.GA18821@hili.localdomain> References: <1374365254-13227-1-git-send-email-novalazy@gmail.com> <87ip048gbj.fsf@qmul.ac.uk> <20130727151510.GA13750@hili.localdomain> <87hadtxfrr.fsf@qmul.ac.uk> <20130912001349.GA18821@hili.localdomain> User-Agent: Notmuch/0.16+92~g54c40fb (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Thu, 10 Oct 2013 07:41:07 -0300 Message-ID: <87zjqhv264.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Oct 2013 10:41:17 -0000 Peter Wang writes: > On Tue, 10 Sep 2013 09:06:00 +0100, Mark Walters wrote: >> >> Alternatively maybe add notmuch_database_destroy_with_flush or something >> which does give a return value. notmuch_database_close is only called 3 >> times and notmuch_database_destroy lots of times so changing close is >> much less intrusive than changing destroy. But I don't know whether we >> would break any bindings or external programs etc. >> >> What do you think? > > I think notmuch_database_close and notmuch_database_destroy should > return the status, and we update the three language bindings > and bump the soname. > I'm not opposed to doing an SONAME bump for 0.17. Are there other ABI breaking changes that we have been holding back on? Can these maybe go through at the same time? d