From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 16040431FBC
	for <notmuch@notmuchmail.org>; Fri, 24 Jan 2014 16:42:14 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 3F9z5P2azsbN for <notmuch@notmuchmail.org>;
	Fri, 24 Jan 2014 16:42:06 -0800 (PST)
Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id CFFB4431FB6
	for <notmuch@notmuchmail.org>; Fri, 24 Jan 2014 16:42:06 -0800 (PST)
Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
	(envelope-from <david@tethera.net>)
	id 1W6rJx-0006uc-Di; Fri, 24 Jan 2014 20:42:01 -0400
Received: (nullmailer pid 31424 invoked by uid 1000); Sat, 25 Jan 2014
	00:41:57 -0000
From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 3/3] notmuch-show: detect xapian exception in query
In-Reply-To: <87txctf5ip.fsf@nikula.org>
References: <m2r47zrkkc.fsf@guru.guru-group.fi>
	<1390479841-17045-1-git-send-email-david@tethera.net>
	<1390479841-17045-4-git-send-email-david@tethera.net>
	<87txctf5ip.fsf@nikula.org>
User-Agent: Notmuch/0.17+35~g3b36898 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Fri, 24 Jan 2014 20:41:57 -0400
Message-ID: <87zjmkopt6.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 25 Jan 2014 00:42:14 -0000

Jani Nikula <jani@nikula.org> writes:
>
> This should just return 1 or something. See how the function eventually
> returns res != NOTMUCH_STATUS_SUCCESS instead of notmuch_status_t. And
> threads == NULL is not guaranteed to mean an exception occurred anyway.
>
> Otherwise the patch LGTM, and is in line with the error handling in
> notmuch search, which does not segfault on similar queries.

pushed a version amended as suggested.

d