unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Jani Nikula <jani@nikula.org>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 0/7] emacs: show tag changes in buffer
Date: Thu, 06 Mar 2014 07:37:27 +0100	[thread overview]
Message-ID: <87zjl36deg.fsf@nikula.org> (raw)
In-Reply-To: <1392841212-8494-1-git-send-email-markwalters1009@gmail.com>

On Wed, 19 Feb 2014, Mark Walters <markwalters1009@gmail.com> wrote:
> This is v2 of the patch set. Version 1 is at
> id:1390087855-26194-1-git-send-email-markwalters1009@gmail.com.
>
> The changes in this version are: use regexp tag-format matching (a
> slightly tweaked version of Austin's patch
> id:1392226351-31440-1-git-send-email-amdragon@mit.edu), make the
> tag-deleted/added formats apply on top of the normal tag-formatting,
> and fixup the way the :orig-tags field is added in notmuch-search.
>
> I think this version fixes all outstanding review comments.

Just for the record, I've been using this version for a while (and the
previous versions before that), and I still think it's one of the best
emacs UI improvements we've had lately. Would be great to have this
merged.

BR,
Jani.


>
> Best wishes
>
> Mark
>
>
>
> Austin Clements (1):
>   Make keys of notmuch-tag-formats regexps and use caching
>
> Mark Walters (6):
>   emacs: tag split customise option for format-tags into a widget
>   emacs: tag: add customize for deleted/added tag formats
>   emacs: show: mark tags changed since buffer loaded
>   emacs: show: use orig-tags for tag display
>   emacs: search: use orig-tags in search
>   emacs: tree: use orig-tags in search
>
>  emacs/notmuch-show.el |    7 ++-
>  emacs/notmuch-tag.el  |  179 +++++++++++++++++++++++++++++++++++++-----------
>  emacs/notmuch-tree.el |   10 ++-
>  emacs/notmuch.el      |   41 +++++++-----
>  test/test-lib.el      |    5 ++
>  5 files changed, 180 insertions(+), 62 deletions(-)
>
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

      parent reply	other threads:[~2014-03-06  6:37 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-19 20:20 [PATCH v2 0/7] emacs: show tag changes in buffer Mark Walters
2014-02-19 20:20 ` [PATCH v2 1/7] Make keys of notmuch-tag-formats regexps and use caching Mark Walters
2014-03-11  2:06   ` Austin Clements
2014-02-19 20:20 ` [PATCH v2 2/7] emacs: tag split customise option for format-tags into a widget Mark Walters
2014-02-19 20:20 ` [PATCH v2 3/7] emacs: tag: add customize for deleted/added tag formats Mark Walters
2014-03-11  2:09   ` Austin Clements
2014-03-11  2:37   ` Austin Clements
2014-03-11 14:46     ` [PATCH] emacs: Combine notmuch-combine-face-text-property{,-string} Austin Clements
2014-02-19 20:20 ` [PATCH v2 4/7] emacs: show: mark tags changed since buffer loaded Mark Walters
2014-03-11  2:29   ` Austin Clements
2014-02-19 20:20 ` [PATCH v2 5/7] emacs: show: use orig-tags for tag display Mark Walters
2014-02-19 20:20 ` [PATCH v2 6/7] emacs: search: use orig-tags in search Mark Walters
2014-02-22 11:25   ` [PATCH v2.1 " Mark Walters
2014-03-11  2:41     ` Austin Clements
2014-02-19 20:20 ` [PATCH v2 7/7] emacs: tree: " Mark Walters
2014-03-06  6:37 ` Jani Nikula [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zjl36deg.fsf@nikula.org \
    --to=jani@nikula.org \
    --cc=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).