[PATCH] emacs: push mark before signature on reply

[PATCH] emacs: push mark before signature on reply

[Jani Nikula]

We push mark on reply so user can cut the quote. Push the mark before
signature, if any, instead of end of buffer so the signature is
preserved.

This is consistent with message-kill-to-signature.
---
 emacs/notmuch-mua.el | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index b16a10ecd379..ba3ef275ec5e 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -226,8 +226,12 @@ list."
 	;; Quote the original message according to the user's configured style.
 	(message-cite-original))))
 
-  (goto-char (point-max))
+  ;; Push mark right before signature, if any.
+  (message-goto-signature)
+  (unless (eobp)
+    (end-of-line -1))
   (push-mark)
+
   (message-goto-body)
   (set-buffer-modified-p nil))
 
-- 
1.9.0

Re: [PATCH] emacs: push mark before signature on reply

[Tomi Ollila]

On Fri, Mar 28 2014, Jani Nikula <jani@nikula.org> wrote:

> We push mark on reply so user can cut the quote. Push the mark before
> signature, if any, instead of end of buffer so the signature is
> preserved.
>
> This is consistent with message-kill-to-signature.
> ---

LGTM. +1

>  emacs/notmuch-mua.el | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index b16a10ecd379..ba3ef275ec5e 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -226,8 +226,12 @@ list."
>  	;; Quote the original message according to the user's configured style.
>  	(message-cite-original))))
>  
> -  (goto-char (point-max))
> +  ;; Push mark right before signature, if any.
> +  (message-goto-signature)
> +  (unless (eobp)
> +    (end-of-line -1))
>    (push-mark)
> +
>    (message-goto-body)
>    (set-buffer-modified-p nil))
>  
> -- 
> 1.9.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: push mark before signature on reply

[Mark Walters]

LGTM +1

Best wishes

Mark

On Fri, 28 Mar 2014, Jani Nikula <jani@nikula.org> wrote:
> We push mark on reply so user can cut the quote. Push the mark before
> signature, if any, instead of end of buffer so the signature is
> preserved.
>
> This is consistent with message-kill-to-signature.
> ---
>  emacs/notmuch-mua.el | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index b16a10ecd379..ba3ef275ec5e 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -226,8 +226,12 @@ list."
>  	;; Quote the original message according to the user's configured style.
>  	(message-cite-original))))
>  
> -  (goto-char (point-max))
> +  ;; Push mark right before signature, if any.
> +  (message-goto-signature)
> +  (unless (eobp)
> +    (end-of-line -1))
>    (push-mark)
> +
>    (message-goto-body)
>    (set-buffer-modified-p nil))
>  
> -- 
> 1.9.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: push mark before signature on reply

[David Bremner]

Jani Nikula <jani@nikula.org> writes:

> We push mark on reply so user can cut the quote. Push the mark before
> signature, if any, instead of end of buffer so the signature is
> preserved.
>
> This is consistent with message-kill-to-signature.

Pushed.

d