From: Jani Nikula <jani@nikula.org>
To: Tomi Ollila <tomi.ollila@iki.fi>,
David Bremner <david@tethera.net>,
notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] completion: complete notmuch insert --folder to maildir folders only
Date: Thu, 01 Jan 2015 16:33:45 +0200 [thread overview]
Message-ID: <87zja2woxi.fsf@nikula.org> (raw)
In-Reply-To: <m2a922hf81.fsf@guru.guru-group.fi>
On Thu, 01 Jan 2015, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> On Wed, Dec 31 2014, David Bremner <david@tethera.net> wrote:
>
>> Jani Nikula <jani@nikula.org> writes:
>>> + local path=`notmuch config get database.path`
>>> + compopt -o nospace
>>> + COMPREPLY=( $(compgen -d "$path/${cur##folder:}" | \
>>> + sed "s|^$path/||" | grep -v "\(^\|/\)\(cur\|new\|tmp\)$"
>>
>> I'm a bit confused here. Why is 'folder:' being stripped? Too much
>> copy-pasta?
>
> compgen -d wants a directory ?
>
> there seems to be similar strippings done in completion of
> notmuch_search_terms.
True, but $cur won't have folder: here. Copy-paste fail.
Jani.
>
>>
>> d
>
> Tomi
>
> PS: if it weren't inconsistent change, just on '#' would suffice ;)
next prev parent reply other threads:[~2015-01-01 14:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 19:35 [PATCH 1/2] completion: complete notmuch insert --keep and --no-hooks options Jani Nikula
2014-11-10 19:35 ` [PATCH 2/2] completion: complete notmuch insert --folder to maildir folders only Jani Nikula
2014-12-31 20:36 ` David Bremner
2015-01-01 12:12 ` Tomi Ollila
2015-01-01 14:33 ` Jani Nikula [this message]
2015-01-01 14:34 ` [PATCH v2] " Jani Nikula
2015-01-02 16:22 ` [PATCH 1/2] completion: complete notmuch insert --keep and --no-hooks options David Bremner
2015-01-02 17:58 ` Jani Nikula
2015-01-02 18:03 ` [PATCH] completion: remove the broken notmuch-completion.tcsh Jani Nikula
2015-01-02 19:57 ` Tomi Ollila
2015-01-03 8:46 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zja2woxi.fsf@nikula.org \
--to=jani@nikula.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).