From: Michal Sojka <sojkam1@fel.cvut.cz>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/3] emacs: Fix mail composition under Emacs 23
Date: Wed, 06 Jan 2016 22:27:46 +0100 [thread overview]
Message-ID: <87ziwiv1nx.fsf@steelpick.2x.cz> (raw)
In-Reply-To: <8760z8ah7e.fsf@zancas.localnet>
On Tue, Jan 05 2016, David Bremner wrote:
> Michal Sojka <sojkam1@fel.cvut.cz> writes:
>
>> + (when return-action (nconc args '(return-action)))
>> + (apply 'message-setup-1
>> + ;; The following sexp is copied from `message-mail'
>
>> + (nconc
>> + `((To . ,(or to "")) (Subject . ,(or subject "")))
>
> I missed this the first time, but I a bit worried about this used of
> nconc. It seems to fall under "A common pitfall is to use a quoted
> constant list as a non-last argument to ‘nconc’" (from the elisp
> manual). In any case it's not really performance critical code (I
> guess?) so maybe we could just use append?
Yes, this make sense. As the nconc is already in master, I'll not
combine the fix for this with 1/3, but I'm sending a separate patch that
applies after 3/3.
-Michal
next prev parent reply other threads:[~2016-01-06 21:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-02 16:47 notmuch-message-mode initialization follow-up Michal Sojka
2016-01-02 16:47 ` [PATCH 1/3] emacs: Fix mail composition under Emacs 23 Michal Sojka
2016-01-05 2:33 ` David Bremner
2016-01-06 21:27 ` Michal Sojka [this message]
2016-01-06 21:28 ` [PATCH] emacs: Don't use nconc on quoted list Michal Sojka
2016-01-02 16:47 ` [PATCH 2/3] emacs: Refactor notmuch-mua-mail Michal Sojka
2016-01-02 16:47 ` [PATCH 3/3] emacs: Handle switch-function argument of notmuch-mua-mail Michal Sojka
2016-01-08 12:41 ` David Bremner
2016-01-02 18:20 ` notmuch-message-mode initialization follow-up Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ziwiv1nx.fsf@steelpick.2x.cz \
--to=sojkam1@fel.cvut.cz \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).