From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 706086DE096A for ; Thu, 29 Sep 2016 04:41:40 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.007 X-Spam-Level: X-Spam-Status: No, score=-0.007 tagged_above=-999 required=5 tests=[AWL=0.004, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qFR2BNbZ70we for ; Thu, 29 Sep 2016 04:41:39 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id D3EE86DE01CE for ; Thu, 29 Sep 2016 04:41:38 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2) (envelope-from ) id 1bpZiN-0005gr-44; Thu, 29 Sep 2016 07:41:23 -0400 Received: (nullmailer pid 11260 invoked by uid 1000); Thu, 29 Sep 2016 11:41:31 -0000 From: David Bremner To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH] configure: add set -u In-Reply-To: <1462558285-10936-1-git-send-email-tomi.ollila@iki.fi> References: <1462296224-768-1-git-send-email-tomi.ollila@iki.fi> <1462558285-10936-1-git-send-email-tomi.ollila@iki.fi> Date: Thu, 29 Sep 2016 08:41:31 -0300 Message-ID: <87zimrhr10.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2016 11:41:40 -0000 Tomi Ollila writes: > In case of any unset variable, make ./configure exit with nonzero value; > an attempt to expand an unset variable is a bug in the script > (usually a spelling mistake) and those should not pass through > unnoticed. > --- > > I was also doing set -e support but that has quite a few nontrivial > things in it. Set -u catches all lagging c++ compilers and so on ;). > Perhaps later. This commit has an unintended consequence: on unknown platforms, configure crashes and doesn't generate Makefile.config at all. In particular this manifests on Debian/kfreebsd but I imagine there are other platforms where people are just ignoring the "Notmuch might or might not build correctly". I'm tempted to revert the commit for now, and give ourselves some time after the release of 0.23 to figure out (and test) the best solution. d