From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH] configure: add set -u
Date: Thu, 29 Sep 2016 08:41:31 -0300 [thread overview]
Message-ID: <87zimrhr10.fsf@zancas.localnet> (raw)
In-Reply-To: <1462558285-10936-1-git-send-email-tomi.ollila@iki.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
> In case of any unset variable, make ./configure exit with nonzero value;
> an attempt to expand an unset variable is a bug in the script
> (usually a spelling mistake) and those should not pass through
> unnoticed.
> ---
>
> I was also doing set -e support but that has quite a few nontrivial
> things in it. Set -u catches all lagging c++ compilers and so on ;).
> Perhaps later.
This commit has an unintended consequence: on unknown platforms,
configure crashes and doesn't generate Makefile.config at all. In
particular this manifests on Debian/kfreebsd but I imagine there are
other platforms where people are just ignoring the "Notmuch might or
might not build correctly". I'm tempted to revert the commit for now,
and give ourselves some time after the release of 0.23 to figure out
(and test) the best solution.
d
prev parent reply other threads:[~2016-09-29 11:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 17:23 [PATCH] configure: replace ${CXXLAGS} with ${CXXFLAGS_for_sh} Tomi Ollila
2016-05-06 18:11 ` [PATCH] configure: add set -u Tomi Ollila
2016-05-07 22:27 ` David Bremner
2016-09-29 11:41 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zimrhr10.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).