From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: [David Bremner] Re: [PATCH] cli/new: Avoid printing "\033[K" to non-terminal output
Date: Thu, 09 Mar 2017 09:51:43 -0400 [thread overview]
Message-ID: <87zigu4ky8.fsf@tethera.net> (raw)
[-- Attachment #0: Type: message/rfc822, Size: 1418 bytes --]
From: David Bremner <david@tethera.net>
To: "Łukasz Stelmach" <l.stelmach@samsung.com>
Subject: Re: [PATCH] cli/new: Avoid printing "\033[K" to non-terminal output
Date: Thu, 09 Mar 2017 08:35:11 -0400
Message-ID: <87bmta6328.fsf@tethera.net>
Łukasz Stelmach <l.stelmach@samsung.com> writes:
> ---
> notmuch-new.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/notmuch-new.c b/notmuch-new.c
> index 1321263..44174ad 100644
> --- a/notmuch-new.c
> +++ b/notmuch-new.c
> @@ -905,10 +905,9 @@ print_results (const add_files_state_t *state)
> state->processed_files == 1 ? "file" : "total files");
> notmuch_time_print_formatted_seconds (elapsed);
> if (elapsed > 1)
> - printf (" (%d files/sec.).\033[K\n",
> + printf (" (%d files/sec.)",
> (int) (state->processed_files / elapsed));
> - else
> - printf (".\033[K\n");
> + printf(".%s\n", (state->output_is_a_tty) ? "\033[K" : "");
> }
Other than missing a space after printf (which I can hopefully remember
to add when I commit it, this looks fine).
d
next reply other threads:[~2017-03-09 13:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 13:51 David Bremner [this message]
2017-03-09 15:44 ` [David Bremner] Re: [PATCH] cli/new: Avoid printing "\033[K" to non-terminal output Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zigu4ky8.fsf@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).