unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] CLI/restore: handle missing keys and values in config data.
Date: Sun, 07 Jan 2018 18:10:51 -0500	[thread overview]
Message-ID: <87zi5p8dtw.fsf@fifthhorseman.net> (raw)
In-Reply-To: <20180107213025.12848-1-david@tethera.net>

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

On Sun 2018-01-07 17:30:25 -0400, David Bremner wrote:
> Although such lines can't occur in notmuch dump output, they might be
> useful for clearing config, and anyway segfaulting is not the best
> error message.

I don't think we want "notmuch restore" to actually clear any
configurations (it's always been additive thus far and changing that
seems dicey to me), but the patch itself here looks good to me.

thanks for fixing the segfault, bremner.

       --dkg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2018-01-07 23:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-07 21:30 [PATCH] CLI/restore: handle missing keys and values in config data David Bremner
2018-01-07 23:10 ` Daniel Kahn Gillmor [this message]
2018-01-08  0:12   ` David Bremner
2018-02-09 16:52     ` Daniel Kahn Gillmor
2018-02-15  5:53       ` Tomi Ollila
2018-02-18  5:05         ` Daniel Kahn Gillmor
2018-02-18 11:37       ` David Bremner
2018-04-30 11:11   ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zi5p8dtw.fsf@fifthhorseman.net \
    --to=dkg@fifthhorseman.net \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).