From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id B6C556DE0C3D
 for <notmuch@notmuchmail.org>; Mon, 11 Mar 2019 02:59:10 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: -0.012
X-Spam-Level: 
X-Spam-Status: No, score=-0.012 tagged_above=-999 required=5
 tests=[AWL=-0.011, SPF_PASS=-0.001] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 6BSlARttdH0b for <notmuch@notmuchmail.org>;
 Mon, 11 Mar 2019 02:59:10 -0700 (PDT)
Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
 by arlo.cworth.org (Postfix) with ESMTPS id EB99D6DE0AB2
 for <notmuch@notmuchmail.org>; Mon, 11 Mar 2019 02:59:09 -0700 (PDT)
Received: from remotemail by fethera.tethera.net with local (Exim 4.89)
 (envelope-from <david@tethera.net>)
 id 1h3Hi7-0005yV-9r; Mon, 11 Mar 2019 05:59:07 -0400
Received: (nullmailer pid 6568 invoked by uid 1000);
 Mon, 11 Mar 2019 09:59:06 -0000
From: David Bremner <david@tethera.net>
To: Luis Ressel <aranea@aixah.de>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] test: Ignore subtly different behaviour of the musl libc
In-Reply-To: <20190310192924.kgerioqcmbvj6ang@deneb.skynet.aixah.de>
References: <20190226020629.5273-1-aranea@aixah.de>
 <87zhqax2uy.fsf@tethera.net>
 <20190310192924.kgerioqcmbvj6ang@deneb.skynet.aixah.de>
Date: Mon, 11 Mar 2019 06:59:06 -0300
Message-ID: <87zhq1d95h.fsf@tethera.net>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Mar 2019 09:59:10 -0000

Luis Ressel <aranea@aixah.de> writes:

> If you really consider it important to convey the info that there was a
> regex parsing error, I can submit a patch to make compile_regex() prefix
> the regerror output with "regex error: " or sth like that.

That sounds good. The exception loses all location information at the C
boundary, so the message is all we have. The test was originally added
to make sure the regexp error checking (such as it is) was working, and
I'd like to preserve that if possible.

d