unofficial mirror of notmuch@notmuchmail.org
 help / color / Atom feed
* [PATCH] python-cffi: enable out-of-tree builds
@ 2020-05-22  1:03 Daniel Kahn Gillmor
  2020-05-26 15:22 ` Daniel Kahn Gillmor
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Kahn Gillmor @ 2020-05-22  1:03 UTC (permalink / raw)
  To: Notmuch Mail

This is a simple hack to enable out-of-tree builds, a concern raised
by Tomi in id:m24kzjib9a.fsf@guru.guru-group.fi

This change at least enables "make check" to complete without error,
but I'm sure it could be improved.  I am not expert enough in
setuptools to know how.

Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
---
 configure | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/configure b/configure
index 37368bda..f0472e8e 100755
--- a/configure
+++ b/configure
@@ -70,6 +70,14 @@ if [ "$srcdir" != "." ]; then
     mkdir bindings/ruby
     cp -a "$srcdir"/bindings/ruby/*.[ch] bindings/ruby
     cp -a "$srcdir"/bindings/ruby/extconf.rb bindings/ruby
+
+    # Use the same hack to replicate python-cffi source for
+    # out-of-tree builds (again, not ideal).
+    mkdir bindings/python-cffi
+    cp -a "$srcdir"/bindings/python-cffi/tests \
+       "$srcdir"/bindings/python-cffi/notmuch2 \
+       "$srcdir"/bindings/python-cffi/setup.py \
+       bindings/python-cffi/
 fi
 
 # Set several defaults (optionally specified by the user in
-- 
2.26.2

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] python-cffi: enable out-of-tree builds
  2020-05-22  1:03 [PATCH] python-cffi: enable out-of-tree builds Daniel Kahn Gillmor
@ 2020-05-26 15:22 ` Daniel Kahn Gillmor
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Kahn Gillmor @ 2020-05-26 15:22 UTC (permalink / raw)
  To: Notmuch Mail


[-- Attachment #1.1: Type: text/plain, Size: 805 bytes --]

On Thu 2020-05-21 21:03:59 -0400, Daniel Kahn Gillmor wrote:
> This is a simple hack to enable out-of-tree builds, a concern raised
> by Tomi in id:m24kzjib9a.fsf@guru.guru-group.fi
>
> This change at least enables "make check" to complete without error,
> but I'm sure it could be improved.  I am not expert enough in
> setuptools to know how.

in id:87d06usa31.fsf@powell.devork.be, Floris said:

>> It probably is indeed the unfortunate case that copying the python
>> source is currently the easiest.  I had a quick look and it seemed like
>> one'd have to dig into the cffi setuptools support to make this work and
>> I'm not sure how successful that would be, but I admit I didn't feel
>> like trying.

So i've removed notmuch::needs-review -- sounds like this is currently
the way to go.

   --dkg

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-22  1:03 [PATCH] python-cffi: enable out-of-tree builds Daniel Kahn Gillmor
2020-05-26 15:22 ` Daniel Kahn Gillmor

unofficial mirror of notmuch@notmuchmail.org

Archives are clonable:
	git clone --mirror https://yhetil.org/notmuch/0 notmuch/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 notmuch notmuch/ https://yhetil.org/notmuch \
		notmuch@notmuchmail.org
	public-inbox-index notmuch

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.mail.notmuch.general
	nntp://news.gmane.io/gmane.mail.notmuch.general


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git