From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] python-cffi: enable out-of-tree builds
Date: Tue, 26 May 2020 11:22:58 -0400 [thread overview]
Message-ID: <87zh9uhga5.fsf@fifthhorseman.net> (raw)
In-Reply-To: <20200522010359.715688-1-dkg@fifthhorseman.net>
[-- Attachment #1.1: Type: text/plain, Size: 805 bytes --]
On Thu 2020-05-21 21:03:59 -0400, Daniel Kahn Gillmor wrote:
> This is a simple hack to enable out-of-tree builds, a concern raised
> by Tomi in id:m24kzjib9a.fsf@guru.guru-group.fi
>
> This change at least enables "make check" to complete without error,
> but I'm sure it could be improved. I am not expert enough in
> setuptools to know how.
in id:87d06usa31.fsf@powell.devork.be, Floris said:
>> It probably is indeed the unfortunate case that copying the python
>> source is currently the easiest. I had a quick look and it seemed like
>> one'd have to dig into the cffi setuptools support to make this work and
>> I'm not sure how successful that would be, but I admit I didn't feel
>> like trying.
So i've removed notmuch::needs-review -- sounds like this is currently
the way to go.
--dkg
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2020-05-26 16:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 1:03 [PATCH] python-cffi: enable out-of-tree builds Daniel Kahn Gillmor
2020-05-26 15:22 ` Daniel Kahn Gillmor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh9uhga5.fsf@fifthhorseman.net \
--to=dkg@fifthhorseman.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).